-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User: this pr enables user to logout from one's session #187984515 #30
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #30 +/- ##
==========================================
- Coverage 74.09% 73.82% -0.28%
==========================================
Files 83 87 +4
Lines 2027 2101 +74
Branches 306 322 +16
==========================================
+ Hits 1502 1551 +49
- Misses 514 525 +11
- Partials 11 25 +14 ☔ View full report in Codecov by Sentry. |
9e631c9
to
cb91c17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MugemaneBertin2001 I can see the way to test this feature.
cb91c17
to
cfa7a1e
Compare
cfa7a1e
to
d79a975
Compare
d79a975
to
ab0f732
Compare
ab0f732
to
711b2ad
Compare
711b2ad
to
3a10531
Compare
3a10531
to
8fc4bad
Compare
8fc4bad
to
c556f66
Compare
c556f66
to
caa8530
Compare
caa8530
to
57732c7
Compare
57732c7
to
1b7321e
Compare
1b7321e
to
3a7b49b
Compare
3a7b49b
to
3f37262
Compare
3f37262
to
6ac69bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6ac69bc
to
e3d3bb8
Compare
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
7139998 | Triggered | Generic Password | 18a6db3 | src/test/login.test.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
e3d3bb8
to
8828c47
Compare
8828c47
to
14df61d
Compare
14df61d
to
18a6db3
Compare
Code Climate has analyzed commit 18a6db3 and detected 0 issues on this pull request. View more on Code Climate. |
What does this PR do?
This PR Adds Logout feature in
eagle-ec-fe
Description of Task to be completed?
How should this be manually tested?
ft-user-logout-#187984515
.npm install
to install dependencies.npm run dev
to start the development serverhttp://localhost:5173/
What are the relevant pivotal tracker stories?
Delivers #187984515