Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User: this pr enables user to logout from one's session #187984515 #30

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

MugemaneBertin2001
Copy link
Collaborator

@MugemaneBertin2001 MugemaneBertin2001 commented Jul 25, 2024

What does this PR do?

This PR Adds Logout feature in eagle-ec-fe

Description of Task to be completed?

  • Remove the access token from local storage
  • To blacklist used accesstoken

How should this be manually tested?

  1. Clone the repository.
  2. Checkout to the branch ft-user-logout-#187984515.
  3. Run npm install to install dependencies.
  4. Run npm run dev to start the development server
  5. Access the app on http://localhost:5173/
  6. Log into your account
  7. Logout using logout button on bottom of sidebar

What are the relevant pivotal tracker stories?

Delivers #187984515

Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eagles-ec-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 11:22am

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 63.00000% with 37 lines in your changes missing coverage. Please review.

Project coverage is 73.82%. Comparing base (968b444) to head (18a6db3).

Files Patch % Lines
src/pages/Login.tsx 13.33% 13 Missing ⚠️
src/components/common/ProfileDropdown.tsx 18.18% 9 Missing ⚠️
src/components/dashboard/Header.tsx 37.50% 4 Missing and 1 partial ⚠️
src/redux/ProtectDashboard.tsx 76.47% 3 Missing and 1 partial ⚠️
src/redux/api/api.ts 50.00% 3 Missing ⚠️
src/components/dashboard/HomeButton.tsx 87.50% 1 Missing ⚠️
src/components/dashboard/admin/LogoutContext.tsx 95.23% 1 Missing ⚠️
src/components/dashboard/admin/LogoutModal.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #30      +/-   ##
==========================================
- Coverage   74.09%   73.82%   -0.28%     
==========================================
  Files          83       87       +4     
  Lines        2027     2101      +74     
  Branches      306      322      +16     
==========================================
+ Hits         1502     1551      +49     
- Misses        514      525      +11     
- Partials       11       25      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@niyobertin niyobertin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MugemaneBertin2001 I can see the way to test this feature.

@MugemaneBertin2001 MugemaneBertin2001 force-pushed the ft-user-logout-#187984515 branch from cb91c17 to cfa7a1e Compare July 26, 2024 15:08
@MugemaneBertin2001 MugemaneBertin2001 force-pushed the ft-user-logout-#187984515 branch from cfa7a1e to d79a975 Compare July 26, 2024 15:16
@MugemaneBertin2001 MugemaneBertin2001 added the In progress a work in progress label Jul 26, 2024
@MugemaneBertin2001 MugemaneBertin2001 force-pushed the ft-user-logout-#187984515 branch from d79a975 to ab0f732 Compare July 26, 2024 15:21
@MugemaneBertin2001 MugemaneBertin2001 force-pushed the ft-user-logout-#187984515 branch from ab0f732 to 711b2ad Compare July 28, 2024 20:43
@MugemaneBertin2001 MugemaneBertin2001 force-pushed the ft-user-logout-#187984515 branch from 711b2ad to 3a10531 Compare July 28, 2024 20:50
@MugemaneBertin2001 MugemaneBertin2001 force-pushed the ft-user-logout-#187984515 branch from 3a10531 to 8fc4bad Compare July 28, 2024 21:24
@MugemaneBertin2001 MugemaneBertin2001 force-pushed the ft-user-logout-#187984515 branch from 8fc4bad to c556f66 Compare July 28, 2024 21:43
@MugemaneBertin2001 MugemaneBertin2001 force-pushed the ft-user-logout-#187984515 branch from c556f66 to caa8530 Compare July 28, 2024 22:34
@MugemaneBertin2001 MugemaneBertin2001 force-pushed the ft-user-logout-#187984515 branch from caa8530 to 57732c7 Compare July 28, 2024 23:07
Copy link
Collaborator

@niyobertin niyobertin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MugemaneBertin2001 MugemaneBertin2001 force-pushed the ft-user-logout-#187984515 branch from 6ac69bc to e3d3bb8 Compare July 29, 2024 09:58
Copy link

gitguardian bot commented Jul 29, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
7139998 Triggered Generic Password 18a6db3 src/test/login.test.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@MugemaneBertin2001 MugemaneBertin2001 force-pushed the ft-user-logout-#187984515 branch from 14df61d to 18a6db3 Compare July 29, 2024 11:21
Copy link

codeclimate bot commented Jul 29, 2024

Code Climate has analyzed commit 18a6db3 and detected 0 issues on this pull request.

View more on Code Climate.

@teerenzo teerenzo merged commit c3ed50d into dev Jul 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants