Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product should be enebled or disbled #31

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Product should be enebled or disbled #31

merged 2 commits into from
Jul 29, 2024

Conversation

niyobertin
Copy link
Collaborator

What does this PR do ?

Seller shuld be able to avail or un vail products

How should manualy be tested?

  • clone the repo
  • cd into it
  • checkout to the branch product-avail-unavail
    run: npm to install dependences
    run npm run dev to stat the server

navigate to http://localhost:5173/ then login as seller. you will be redirected to dashboard then vist product page. you will be able to avail and unavail products

Screen shoot

Screenshot 2024-07-26 at 21 46 41

-when token is expired user should be redirected to login page
Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eagles-ec-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 8:31am

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 73.92%. Comparing base (1186659) to head (49c7710).

Files Patch % Lines
src/redux/reducers/productsSlice.ts 37.50% 5 Missing ⚠️
src/redux/reducers/wishListSlice.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #31      +/-   ##
==========================================
+ Coverage   73.47%   73.92%   +0.44%     
==========================================
  Files          82       82              
  Lines        1987     1998      +11     
  Branches      303      305       +2     
==========================================
+ Hits         1460     1477      +17     
+ Misses        504      498       -6     
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@yvanddniyo yvanddniyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…able a products

-Ensure that product should be able to be disbled when it is Enebled
-ensure that product should be anble to enable be enebled when a product is disabled
@niyobertin niyobertin force-pushed the product-avail-unavail branch from 723b270 to 49c7710 Compare July 29, 2024 08:31
Copy link

codeclimate bot commented Jul 29, 2024

Code Climate has analyzed commit 49c7710 and detected 0 issues on this pull request.

View more on Code Climate.

@teerenzo teerenzo merged commit da7bd42 into dev Jul 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants