Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#187419120 Users should be able to Login with Email and Password #4

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

Heisjabo
Copy link
Collaborator

@Heisjabo Heisjabo commented Jun 11, 2024

What does this PR do?

This PR Adds User login feature so that one should be able to login with email and password

Description of Task to be completed?

  • Implement login page as designed with responsiveness
  • Integration with the backend
  • Testing the feature

How should this be manually tested?

  1. Clone the repository.
  2. Checkout to the branch ft-login-#187419120.
  3. Run npm install to install dependencies.
  4. Run npm run dev to start the development server and navigate to /login
  5. Enter email and password to login

What are the relevant pivotal tracker stories?

Delivers #187419120

Screenshots

Design

Screenshot 2024-06-12 at 4 23 31 PM

Implementation

Screenshot 2024-06-13 at 2 20 30 PM

@Heisjabo Heisjabo added the In progress a work in progress label Jun 11, 2024
Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eagles-ec-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 1:58pm

@teerenzo
Copy link
Member

@Heisjabo pay attention to details (fonts-weight, font-size) are not the same with the design

Copy link
Collaborator

@soleil00 soleil00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@MugemaneBertin2001 MugemaneBertin2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SLGTM

- users should be able to login with email and password

Delivers #187419120
@Heisjabo Heisjabo force-pushed the ft-login-#187419120 branch from 5ba667c to 7cea969 Compare June 13, 2024 13:58
Copy link

codeclimate bot commented Jun 13, 2024

Code Climate has analyzed commit 7cea969 and detected 0 issues on this pull request.

View more on Code Climate.

@teerenzo teerenzo merged commit cb1d400 into dev Jun 13, 2024
6 checks passed
soleil00 pushed a commit that referenced this pull request Jun 18, 2024
#187419120 Users should be able to Login with Email and Password
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants