Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Map and Build classes #25

Merged
merged 9 commits into from
Sep 21, 2023
Merged

Refactor Map and Build classes #25

merged 9 commits into from
Sep 21, 2023

Conversation

atmoos
Copy link
Owner

@atmoos atmoos commented Sep 9, 2023 •
edited
Loading

This paves the way for multiplicative operations on measures, which is a precondition for making quantities independent of units (issue: #10 ).

  • rename Map -> Measure.
  • Remove need for the Builder class.
  • Add Of factory methods on Quantity.

@atmoos atmoos added the enhancement New feature or request label Sep 9, 2023
@atmoos atmoos added this to the First Release milestone Sep 9, 2023
@atmoos atmoos requested a review from sereneowl September 9, 2023 11:12
@atmoos atmoos marked this pull request as ready for review September 9, 2023 11:12
@atmoos atmoos merged commit 8f1ed5e into main Sep 21, 2023
@atmoos atmoos deleted the simplifyMeasures branch September 21, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sereneowl sereneowl Awaiting requested review from sereneowl

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
First Release
Development

Successfully merging this pull request may close these issues.
1 participant
@atmoos