feat: Dockerfiles for e2e tests next iteration #1757
Draft
+441
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is related to #1444 |
cpswan
reviewed
Feb 24, 2025
| @@ -0,0 +1,31 @@ | |||
| FROM dart:3.6.0 | |||
There was a problem hiding this comment.
Should be 3.7.0 and pinned to a hash
There was a problem hiding this comment.
Where can I find instructions on how to do that again?
There was a problem hiding this comment.
Never mind , figured it out :)
…a README in progress
…1, and ssh keys to dockerfile runtimes
XavierChanth
reviewed
Mar 3, 2025
| mkdir -p ${HOMEDIR}/.ssh ${HOMEDIR}/.atsign/keys ; \ | ||
| chown -R ${USER}:${USER} ${HOMEDIR} ; \ | ||
| touch ${HOMEDIR}/.ssh/authorized_keys ; \ | ||
| ex +"%s/^%sudo.*$/%sudo ALL=(ALL:ALL) NOPASSWD:ALL/g" -scwq! /etc/sudoers ; \ |
There was a problem hiding this comment.
why a vim ex command instead of sed?
There was a problem hiding this comment.
This should be the same as sed -e 's/^%sudo.*$/%sudo ALL=(ALL:ALL) NOPASSWD:ALL/g' -i /etc/sudoers and you don't need to install vim & the vim runtime (which is heavier than just vi)
There was a problem hiding this comment.
Done in 64fcfee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
The 4 Dockerfiles are:
c.*.*.*releasev.*.*.*release- How I did it
- How to verify it
- Description for the changelog
feat: Dockerfiles for e2e tests next iteration