Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container Security & CI/CD Pipeline Implementation #7

Merged
merged 12 commits into from
Oct 30, 2024
Merged

Container Security & CI/CD Pipeline Implementation #7

merged 12 commits into from
Oct 30, 2024

Conversation

atulgoel126
Copy link
Owner

This PR implements container security scanning and CI/CD pipeline improvements for Week 2 deliverables:

Changes:

  1. Added Trivy container scanning to CI pipeline
  2. Integrated GitHub Container Registry
  3. Updated GitHub Actions workflow with latest versions
  4. Added Docker build/push job
  5. Improved pipeline security with proper permissions

Security:

  1. Container vulnerability scanning with Trivy
  2. Secure Docker image building and pushing
  3. Updated dependency management using npm ci

Technical Requirements:

  1. GitHub Secrets needed: GITHUB_TOKEN
  2. GitHub Variables needed: AWS_ACCOUNT_ID, AWS_DEFAULT_REGION

Closes tasks for Week 2, Days 5-6

atulgoel126 and others added 12 commits October 30, 2024 12:30
@atulgoel126
Made changes to the ci.yml to build and push the docker image and per…
c344ad6 
…form trivy scans
@AtulGoel
Adding missing package lock file
b1d8c2b
@AtulGoel
removing always running the pipeline in case of failure
99bb52a
@AtulGoel
Added concurrency at the root level to ensure that pipeline runs are …
c577e14 
…cancelled when new ones are triggered

                The needs keyword in the jobs ensures they run sequentially:

                checkov needs build to complete
                docker needs checkov to complete

                If any job fails, the subsequent jobs won't run because of the needs dependency
@AtulGoel
Running the project on my raspberry pi
65d5d0e
@AtulGoel
Revert "Running the project on my raspberry pi"
5a614a0 
This reverts commit 65d5d0e.
@AtulGoel
taking help from chatgpt...
0591061
@AtulGoel
Debugging by removing the trivy step.
dc826c6
@AtulGoel
undoing all changes
4254849
@AtulGoel
fixing the name of the branch
36396e7
@AtulGoel
adding security check step and commenting docker step
dc77969
@AtulGoel
uncommenting the docker code
89b701b
@atulgoel126 atulgoel126 merged commit 31b1836 into main Oct 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atulgoel126 @AtulGoel