feat: add eNear connector package #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paouvrard
force-pushed
the
eNear
branch
2 times, most recently
from
d8729c9 to
a87a58e
Compare
paouvrard
changed the title
Build proof before minting. Check if mint proof was already used before minting and check transfer status during recovery to determine if it was already finalized.
Add ethOnNearSyncHeight and nearOnEthSyncHeight. Convert utils package to .ts.
mfornet
approved these changes
May 26, 2021
There was a problem hiding this comment.
Logic looks good to me.
Good job refactoring into typescript 👍
Is this (aurora-is-near/rainbow-bridge-frontend#233) the PR in the frontend that uses this new changes? I'll review the use of this changes in the frontend next.
yes |
Check for SearchError to differentiate from of types of errors like networking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@near-eth/near-ether@near-eth/utils,find-replacement-txandlite-merkle-patricia-treecontaining functionality common to all packageshttps://enear.onrender.com/