Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add config.json as default file for config_file parameter #860

Closed

Conversation

jeff-auth0
Copy link

🔧 Changes

Add config.json as default file for config_file parameter in export and import commands. As per our documentation here the following command does not require configuration file parameter

a0deploy import --input_file=local/tenant.yaml

But the above command throws error even though there is a file in the folder called config.json

The following parameters were missing. Please add them to your config.json or as an environment variable.

This pull request adds config.json as default from current directory unless --c option is provided and in that case root directory config.json will be ignored.

📚 References

Configuring CLI

🔬 Testing

  1. There are no tests for commands.
  2. I am unable to run existing tests locally.
  3. Contribution guide does not mention how to setup and run tests locally guide

📝 Checklist

  • [N/A] All new/changed/fixed functionality is covered by tests (or N/A)
  • [N/A] I have added documentation for all new/changed functionality (or N/A)

…otherwise export/import throws error and does not recognize config.json as defaul per our documentations
@jeff-auth0 jeff-auth0 requested a review from a team as a code owner November 5, 2023 19:37
@willvedd
Copy link
Contributor

Closing this because while well-intentioned, we have been moving towards a more explicit configuration strategy whereas this would make things more implicit. Further, this may cause some nefarious issues with users who manage multiple configurations or toggle between using and not use a configuration file.

@willvedd willvedd closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants