Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relative path import support for actions directory handler #866

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Nov 22, 2023

🔧 Changes

As reported by #840, actions managed in directory mode produce paths that are relative to the CLI. This is in contrast to other imports, specifically the actions YAML handler, that import relative to the input file. This inconsistency can create confusion and a worse DX for developers unsure how to import code.

The solution here is to add a backup import strategy that targets the action code file relative to the input file. This will ensure backwards compatibility.

📚 References

Related issue: #840

🔬 Testing

Added new test case.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd requested a review from a team as a code owner November 22, 2023 16:20
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ab9ef5) 84.23% compared to head (47bb5d4) 84.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #866   +/-   ##
=======================================
  Coverage   84.23%   84.23%           
=======================================
  Files         115      115           
  Lines        3609     3610    +1     
  Branches      699      700    +1     
=======================================
+ Hits         3040     3041    +1     
  Misses        324      324           
  Partials      245      245           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willvedd willvedd enabled auto-merge (squash) November 22, 2023 21:03
@willvedd willvedd merged commit ae243c5 into master Nov 29, 2023
1 check passed
@willvedd willvedd deleted the gh-840-directory-actions-handler-code-relative-path branch November 29, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants