Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth Params Map tab #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Auth Params Map tab #34

wants to merge 1 commit into from

Conversation

genriquez
Copy link

@genriquez genriquez commented Apr 11, 2019

✏️ Changes

Added Auth Params Map tab to configure whitelisted fields mapping, according to issue #14. Existing code was adapted just to accomodate the new tab in the UI, and map the tab's state to the options.authParamsMap property.

📷 Screenshots

image

🔗 References

UI implementation for dynamic connection parameters.

🎯 Testing

  1. Create custom connection
  2. Set any of the fields of Auth Params Map tab to a custom value (e.g. set access_type to myqueryparam)
  3. Set devtools to persists all network activity
  4. Copy URL from TRY button in Settings tab, add your custom field with a value to the querystring, and navigate to the modified URL (e.g. &access_type=myvalue)
  5. On the authorize endpoint call, the custom field should be in the URL with the value edited onto the URL on previous step (e.g. myqueryparam=myvalue)

✅ This change has been tested in a Webtask (locally)

🚫 This change has unit test coverage

🚫 This change has integration test coverage

🚫 This change has been tested for performance

🚀 Deployment

No dependencies

✅ This can be deployed any time

🎡 Rollout

In order to verify that the deployment was successful we will test the mapping using the steps from the Testing section.

🔥 Rollback

We will rollback if rollout manual test fails.

📄 Procedure

Extension is stateless, so reverting the deployment should be enough. Affected data is managed by Auth0 Management API, and is not affected by this change.

🖥 Appliance

Note to reviewers: ensure that this change is compatible with the Appliance.

@genriquez genriquez changed the title Auth Params tab Auth Params Map tab Apr 11, 2019
Copy link

@mcastany mcastany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants