Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert class methods into properties wherever it is relevant #23

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Convert class methods into properties wherever it is relevant #23

merged 4 commits into from
Jan 9, 2025

Conversation

nandan-bhat
Copy link
Contributor

@nandan-bhat nandan-bhat commented Dec 18, 2024 •
edited
Loading

Description

  • Converted class methods returning complex data into properties.
  • Removed un-wanted properties from the class instance. Converted getters into properties.
  • Added code coverage report config.

Existing:

before

After this PR:

after

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@nandan-bhat nandan-bhat marked this pull request as ready for review January 9, 2025 05:15
@nandan-bhat nandan-bhat requested a review from a team as a code owner January 9, 2025 05:15
@nandan-bhat nandan-bhat merged commit 096b0a4 into master Jan 9, 2025
8 checks passed
@nandan-bhat nandan-bhat deleted the feature/SDK-5450 branch January 9, 2025 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyaneshgouraw-okta gyaneshgouraw-okta gyaneshgouraw-okta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nandan-bhat @gyaneshgouraw-okta