Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support UIImplementation #160

Merged
merged 10 commits into from
Feb 20, 2024
Merged

Support UIImplementation #160

merged 10 commits into from
Feb 20, 2024

Conversation

louischan-oursky
Copy link
Contributor

ref #159

@tung2744
Copy link
Contributor

It looks like the sdk is failed to build

tung2744
tung2744 approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@tung2744 tung2744 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested working

@louischan-oursky
Copy link
Contributor Author

Fixed the build by

  1. Set ALL minimum deployment target to 12 for the SDK (previously the unit test is still on 11)
  2. Update to use Xcode 15.2

@tung2744 tung2744 merged commit ee76ee5 into authgear:main Feb 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tung2744 tung2744 tung2744 approved these changes

Assignees

@tung2744 tung2744

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louischan-oursky @tung2744