Added async client | AUTH-9219 | [DO Not Merge] #37
Conversation
aashishAuthomized
force-pushed
the
feature/async-client
branch
from
b9de2b2
to
793938c
Compare
There was a problem hiding this comment.
We prefer not to maintain both sync/async versions of the individual clients.
So now that we have async connector/platform clients, we can delete sync versions and add sync wrapper functionality to the regular (sync) client class.
(loop = asyncio.get_event_loop(), loop. run_until_complete(/loop. ensure_future()
| def __init__(self, auth_token: str, base_url: str = AUTHOMIZE_API_URL): | ||
| self.auth_token = auth_token | ||
| self.base_url = base_url | ||
| self.session = aiohttp.ClientSession() |
There was a problem hiding this comment.
No.... the session doesn't needs to be awaited.
| raise NotImplementedError() | ||
|
|
||
| async def http_get(self, url, params=None): | ||
| url = self.base_url + url |
There was a problem hiding this comment.
Please use furl for URL construction.
| response.raise_for_status() | ||
|
|
||
| async def http_post(self, url: str, body: Optional[str] = None): | ||
| url = self.base_url + url |
There was a problem hiding this comment.
Please use furl for URL construction.
| response.raise_for_status() | ||
|
|
||
| async def http_delete(self, url: str, params=None): | ||
| url = self.base_url + url |
There was a problem hiding this comment.
Please use furl for URL construction.
|
Kudos, SonarCloud Quality Gate passed!
|
aashishAuthomized
changed the title
🎫 https://authomize.atlassian.net/browse/AUTH-9219