fix: adapt to new eslint rules

docs/oidc-client-ts.api.md

@@ -15,13 +15,13 @@ export class AccessTokenEvents {
     addAccessTokenExpired(cb: AccessTokenCallback): () => void;
     addAccessTokenExpiring(cb: AccessTokenCallback): () => void;
     // (undocumented)
-    load(container: User): Promise<void>;
+    load(container: User): void;
     // (undocumented)
     protected readonly _logger: Logger;
     removeAccessTokenExpired(cb: AccessTokenCallback): void;
     removeAccessTokenExpiring(cb: AccessTokenCallback): void;
     // (undocumented)
-    unload(): Promise<void>;
+    unload(): void;
 }
 
 // @public (undocumented)

jest-environment-jsdom.cjs

@@ -1,11 +1,11 @@
-'use strict';
+"use strict";
 
-const { TextEncoder, TextDecoder } = require('util');
-const { default: $JSDOMEnvironment, TestEnvironment } = require('jest-environment-jsdom');
+const { TextEncoder, TextDecoder } = require("util");
+const { default: $JSDOMEnvironment, TestEnvironment } = require("jest-environment-jsdom");
 const crypto = require("crypto");
 
-Object.defineProperty(exports, '__esModule', {
-    value: true
+Object.defineProperty(exports, "__esModule", {
+    value: true,
 });
 
 class JSDOMEnvironment extends $JSDOMEnvironment {

jest.config.mjs

@@ -11,7 +11,7 @@ export default {
     collectCoverage,
     coverageReporters: collectCoverage ? ["lcov"] : ["lcov", "text"],
     moduleNameMapper: {
-        "^jose": "jose",  // map to jose cjs module otherwise jest breaks
+        "^jose": "jose", // map to jose cjs module otherwise jest breaks
     },
     transform: {
         "^.+\\.tsx?$": [

scripts/build.js

@@ -62,7 +62,7 @@ try {
         globalName: "oidc",
         minify: true,
     });
-} catch (err) {
+} catch {
     // esbuild handles error reporting
     process.exitCode = 1;
 }

src/IndexedDbDPoPStore.ts

@@ -44,7 +44,7 @@ export class IndexedDbDPoPStore implements DPoPStore {
         request: IDBRequest<T> | IDBTransaction): Promise<T> {
         return new Promise<T>((resolve, reject) => {
             (request as IDBTransaction).oncomplete = (request as IDBRequest<T>).onsuccess = () => resolve((request as IDBRequest<T>).result);
-            (request as IDBTransaction).onabort = (request as IDBRequest<T>).onerror = () => reject((request as IDBRequest<T>).error);
+            (request as IDBTransaction).onabort = (request as IDBRequest<T>).onerror = () => reject((request as IDBRequest<T>).error as Error);
         });
     }
 

src/MetadataService.ts

@@ -56,7 +56,8 @@ export class MetadataService {
 
         if (!this._metadataUrl) {
             logger.throw(new Error("No authority or metadataUrl configured on settings"));
-            throw null;
+            // eslint-disable-next-line @typescript-eslint/only-throw-error
+            throw null; // https://github.com/microsoft/TypeScript/issues/46972
         }
 
         logger.debug("getting metadata from", this._metadataUrl);
@@ -138,6 +139,7 @@ export class MetadataService {
 
         if (!Array.isArray(keySet.keys)) {
             logger.throw(new Error("Missing keys on keyset"));
+            // eslint-disable-next-line @typescript-eslint/only-throw-error
             throw null; // https://github.com/microsoft/TypeScript/issues/46972
         }
 

src/OidcClient.ts

@@ -159,12 +159,14 @@ export class OidcClient {
         if (!response.state) {
             logger.throw(new Error("No state in response"));
             // need to throw within this function's body for type narrowing to work
+            // eslint-disable-next-line @typescript-eslint/only-throw-error
             throw null; // https://github.com/microsoft/TypeScript/issues/46972
         }
 
         const storedStateString = await this.settings.stateStore[removeState ? "remove" : "get"](response.state);
         if (!storedStateString) {
             logger.throw(new Error("No matching state found in storage"));
+            // eslint-disable-next-line @typescript-eslint/only-throw-error
             throw null; // https://github.com/microsoft/TypeScript/issues/46972
         }
 
@@ -337,6 +339,7 @@ export class OidcClient {
         const url = await this.metadataService.getEndSessionEndpoint();
         if (!url) {
             logger.throw(new Error("No end session endpoint"));
+            // eslint-disable-next-line @typescript-eslint/only-throw-error
             throw null; // https://github.com/microsoft/TypeScript/issues/46972
         }
 
@@ -387,6 +390,7 @@ export class OidcClient {
         const storedStateString = await this.settings.stateStore[removeState ? "remove" : "get"](response.state);
         if (!storedStateString) {
             logger.throw(new Error("No matching state found in storage"));
+            // eslint-disable-next-line @typescript-eslint/only-throw-error
             throw null; // https://github.com/microsoft/TypeScript/issues/46972
         }
 

src/TokenClient.ts

@@ -114,6 +114,7 @@ export class TokenClient {
             case "client_secret_basic":
                 if (client_secret === undefined || client_secret === null) {
                     logger.throw(new Error("A client_secret is required"));
+                    // eslint-disable-next-line @typescript-eslint/only-throw-error
                     throw null; // https://github.com/microsoft/TypeScript/issues/46972
                 }
                 basicAuth = CryptoUtils.generateBasicAuth(client_id, client_secret);
@@ -175,6 +176,7 @@ export class TokenClient {
             case "client_secret_basic":
                 if (client_secret === undefined || client_secret === null) {
                     logger.throw(new Error("A client_secret is required"));
+                    // eslint-disable-next-line @typescript-eslint/only-throw-error
                     throw null; // https://github.com/microsoft/TypeScript/issues/46972
                 }
                 basicAuth = CryptoUtils.generateBasicAuth(client_id, client_secret);
@@ -231,6 +233,7 @@ export class TokenClient {
             case "client_secret_basic":
                 if (client_secret === undefined || client_secret === null) {
                     logger.throw(new Error("A client_secret is required"));
+                    // eslint-disable-next-line @typescript-eslint/only-throw-error
                     throw null; // https://github.com/microsoft/TypeScript/issues/46972
                 }
                 basicAuth = CryptoUtils.generateBasicAuth(client_id, client_secret);

src/UserManager.ts

@@ -491,7 +491,6 @@ export class UserManager {
                     case "account_selection_required":
                         logger.info("success for anonymous user");
                         return {
-                            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
                             session_state: err.session_state!,
                         };
                 }
@@ -741,7 +740,7 @@ export class UserManager {
         // don't Promise.all, order matters
         for (const type of typesPresent) {
             await this._client.revokeToken(
-                user[type]!, // eslint-disable-line @typescript-eslint/no-non-null-assertion
+                user[type]!,  
                 type,
             );
             logger.info(`${type} revoked successfully`);

src/navigators/AbstractChildWindow.ts

@@ -53,7 +53,7 @@ export abstract class AbstractChildWindow implements IWindow {
                         return;
                     }
                 }
-                catch (err) {
+                catch {
                     this._dispose();
                     reject(new Error("Invalid response from window"));
                 }