Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Bar component #1027

Merged
merged 17 commits into from
Jan 30, 2025
Merged

Search Bar component #1027

merged 17 commits into from
Jan 30, 2025

Conversation

skinread
Copy link
Contributor

  • Adds a search bar component based on react-aria useSearchField. The search box does not implement any searching or filter logic.

  • rolls out WithTestId to Badge, Button and Heading

Copy link

changeset-bot bot commented Jan 24, 2025

🦋 Changeset detected

Latest commit: e9329b4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@autoguru/overdrive Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@skinread skinread marked this pull request as ready for review January 24, 2025 06:30
@skinread skinread requested a review from a team as a code owner January 24, 2025 06:30
lib/components/SearchBar/SearchBar.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@amir-zahedi amir-zahedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the little placeholder animation touch :)
Should we add a changeset to this PR?

lib/components/SearchBar/SearchBar.tsx Show resolved Hide resolved
@skinread skinread requested a review from amir-zahedi January 30, 2025 05:19
@skinread skinread merged commit 72019bd into main Jan 30, 2025
5 checks passed
@skinread skinread deleted the feature/AG-14243-search-bar branch January 30, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants