-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple File Manager #2046
Simple File Manager #2046
Conversation
Note Reviews PausedUse the following commands to manage reviews:
WalkthroughThe update introduces a comprehensive Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Can't think of a way to work around the codeQL issues. I feel like it has been addressed by checking if the path exists within the instructor paths but let me know what you think. |
Changed navbar code
@coderabbitai pause |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than several nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Created File Manager Changed navbar code * Added docs * Changed paths to resource * Sanitized absolute paths * Updated path sanitization * Edited permissions for instructors * Restored path sanitization * Fixed linting issues * More linting * Erblint * Added logic for uploading files with duplicate names * Added routes for base dir * Sanitize path in JS * Removed extra code * Added selected option and uploading multiple files * Upload multiple, create folder, delete selected, checkboxes * Styling and scroll-in-view * Added some tests and added download all * Changed equality check * Removed download of ../ and at top level * Select all checkbox * Select all checkbox and some tests * Instructor check for download * Rebased and added back button for files * Added docs * Changed paths to resource * Sanitized absolute paths * Updated path sanitization * Edited permissions for instructors * Restored path sanitization * Fixed linting issues * More linting * Added logic for uploading files with duplicate names * Added routes for base dir * Removed extra code * Added selected option and uploading multiple files * Upload multiple, create folder, delete selected, checkboxes * Styling and scroll-in-view * Added some tests and added download all * Changed equality check * Removed download of ../ and at top level * Select all checkbox * Select all checkbox and some tests * Instructor check for download * Rebased and added back button for files * Removed whitespace * Addressed null and checkall bugs * Changed permissions for root path * Removed dead code * Fixed rename * Disallow upload of files greater than 1 gb * Added title indexing and updated documentation * Comments about docs and unused code * Fixed expand path * Breadcrumbs and removed routes * Error messages and breadcrumbs * Rubocop fix * erblint * Addressed nits and tests * New name regex * Changed Pathname to str and breadcrumbs * Removed myescape (cherry picked from commit 7cf47d7)
Created a simple file manager that allows an instructor to manage the files and assessments in a course based on the simple file manager found here.
How Has This Been Tested?
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting