Feature/event options #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkabtoul
commented
Oct 13, 2024
mkabtoul
commented
- Adds options to Event for handling the event only once during the node lifetime or adding a delay between consecutive event handling instances
- Adds support for list values in Event source values
- Fixes sending service requests from the monitor
aleph-ra
approved these changes
Oct 13, 2024
ros_sugar/config/base_config.py
Outdated
| @@ -36,7 +36,7 @@ class QoSConfig(BaseAttrs): | |||
|
|
|||
| # used only honored if the “history” policy was set to “keep last” | |||
ros_sugar/core/event.py
Outdated
| @@ -151,7 +177,7 @@ def __init__(self, ros_message: Any, attributes: List[str]) -> None: | |||
| self._message = ros_message | |||
| self._attrs = attributes | |||
| # Get attribute from ros message | |||
| self.value: Union[float, int, bool, str] = _access_attribute( | |||
| self.value: Union[float, int, bool, str, list] = _access_attribute( | |||
There was a problem hiding this comment.
List from typing should be used for 3.8 compatibility
ros_sugar/core/event.py
Outdated
| @@ -284,25 +324,32 @@ def __init__( | |||
| self, | |||
| event_name: str, | |||
| event_source: Union[Topic, str, Dict], | |||
| trigger_value: Union[float, int, bool, str, None], | |||
| trigger_value: Union[float, int, bool, str, list, None], | |||
There was a problem hiding this comment.
List from typing should be used for 3.8 compatibility
ros_sugar/events.py
Outdated
| @@ -153,7 +156,7 @@ def __init__( | |||
| self, | |||
| event_name: str, | |||
| event_source: Union[Topic, str, Dict], | |||
| trigger_value: Union[float, int, bool, str], | |||
| trigger_value: Union[float, int, bool, str, list], | |||
There was a problem hiding this comment.
List from typing should be used
ros_sugar/events.py
Outdated
| @@ -164,7 +167,7 @@ def __init__( | |||
| :param event_source: | |||
| :type event_source: Union[Topic, str, Dict] | |||
| :param trigger_value: | |||
| :type trigger_value: Union[float, int, bool, str] | |||
| :type trigger_value: Union[float, int, bool, str, list] | |||
ros_sugar/events.py
Outdated
| @@ -210,7 +213,7 @@ def __init__( | |||
| self, | |||
| event_name: str, | |||
| event_source: Union[Topic, str, Dict], | |||
| trigger_value: Union[float, int, bool, str], | |||
| trigger_value: Union[float, int, bool, str, list], | |||
ros_sugar/events.py
Outdated
| @@ -221,7 +224,7 @@ def __init__( | |||
| :param event_source: | |||
| :type event_source: Union[Topic, str, Dict] | |||
| :param trigger_value: | |||
| :type trigger_value: Union[float, int, bool, str] | |||
| :type trigger_value: Union[float, int, bool, str, list] | |||
ros_sugar/events.py
Outdated
| @@ -245,7 +323,7 @@ def __init__( | |||
| self, | |||
| event_name: str, | |||
| event_source: Union[Topic, str, Dict], | |||
| trigger_value: Union[float, int, bool, str], | |||
| trigger_value: Union[float, int, bool, str, list], | |||
ros_sugar/events.py
Outdated
| @@ -256,7 +334,7 @@ def __init__( | |||
| :param event_source: | |||
| :type event_source: Union[Topic, str, Dict] | |||
| :param trigger_value: | |||
| :type trigger_value: Union[float, int, bool, str] | |||
| :type trigger_value: Union[float, int, bool, str, list] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.