Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/launch tests #18

Merged
merged 7 commits into from
Jan 28, 2025
Merged

Feature/launch tests #18

merged 7 commits into from
Jan 28, 2025

Conversation

mkabtoul
Copy link
Contributor

Adds launch tests to package:

  • Adds tests for events, actions and component runtypes
  • Fixes existing errors in events
  • Adds support for more std_msgs (MultiArray types)
  • Adds tests to CMakeLists

New flow to run tests:

  • colcon build
  • colcon test --packages-select automatika_ros_sugar

@mkabtoul mkabtoul requested a review from aleph-ra January 27, 2025 17:54
@mkabtoul mkabtoul self-assigned this Jan 27, 2025
Copy link
Contributor

@aleph-ra aleph-ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. But resolve the comment.

@@ -1704,14 +1706,11 @@ def _main(self):
self._exec_started = True

# ABSTRACT METHODS
@abstractmethod
def _execution_step(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is _execution_step not an abstract method now?

@mkabtoul mkabtoul merged commit 0d8559e into main Jan 28, 2025
2 of 4 checks passed
@mkabtoul mkabtoul deleted the feature/launch_tests branch January 28, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants