Reflect board selection in the titlebar #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is looking really good. I think the only feedback I'd give is that I think the multiple-selection state should probably look more like an overlay as the single-card selection does but other than that this looks good to me! |
|
Tried to merge with latest master and now I just can't get things to work again 🤷♂
|
Gozala
force-pushed
the
title-controls
branch
from
4808de9 to
5559c05
Compare
|
@pvh I have rebased pull on top of master and pruned all unrelated changes. So I'd say it's ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of #336. In this version pull is entangled with bunch of other pulls I've submitted, but if things look good I'll rework it to only contain relevant changes.
P.S: I still think that showing board badge when 1 card is selected is kind of pointless & just creates a noise.
No cards selected
A card is selected
Multiple cards are selected