bugfix/fANOVA constant hyperparameters #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sarah-segel
commented
Jan 8, 2024
sarah-segel
commented
- For fANOVA, remove constant hyperparameters from configspace (fANOVA shows nothing (Nan Values from RF) #9).
alexandertornede
suggested changes
Jan 16, 2024
| # Handle constant values in fANOVA: As the fANOVA implementation relies on pyrfr and pyrfr cannot be applied | ||
| # to constant hyperparameters (see https://github.com/automl/fanova/issues/81), as a workaround we remove | ||
| # constant hyperparameters before calculation. | ||
| # Note: This will break if there are conditions or forbiddens including constant hyperparameters. |
There was a problem hiding this comment.
Do we have that documented in the documentation? If not, please add that there as well.
There was a problem hiding this comment.
Added to the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.