just add the domain node block with the consensus block in docker compose #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-astral canceled.
|
DaMandal0rian
changed the title
marc-aurele-besner
requested changes
Mar 4, 2025
marc-aurele-besner
requested changes
Mar 4, 2025
There was a problem hiding this comment.
LGTM
Please add these argument as a commented env like the other taurus env and define a empty env for this, since the uncommented env are by default all the mainnet env
Also, since on mainnet we don't have domain yet, will it create a issue to define port that don't exist?
marc-aurele-besner
requested changes
Mar 4, 2025
There was a problem hiding this comment.
I'm still getting
error: unexpected argument '-- \
node-1 | --domain-id 0 \
node-1 | --state-pruning archive \
node-1 | --blocks-pruning archive \
node-1 | --listen-on /ip4/0.0.0.0/tcp/30334 \
node-1 | --rpc-cors all \
node-1 | --rpc-methods safe \
node-1 | --rpc-listen-on 0.0.0.0:8944 \
node-1 | --rpc-max-connections 500 \
node-1 | --reserved-peer /dns/bootstrap-0.auto-evm.taurus.subspace.network/tcp/30334/p2p/12D3KooWKDhSnpoeyRPRQSNwnB2k1C4WRa8h3BQh5s5mtF9MJdTN \
node-1 | --bootstrap-node /dns/bootstrap-0.auto-evm.taurus.subspace.network/tcp/30334/p2p/12D3KooWKDhSnpoeyRPRQSNwnB2k1C4WRa8h3BQh5s5mtF9MJdTN' found
node-1 |
node-1 | tip: to pass '-- \
...(Even if I hardcode the Domain id in the args)
| NODE_EXTRA_ARGS="" | ||
| #taurus | ||
| # NODE_EXTRA_ARGS="-- \ | ||
| # --domain-id ${DOMAIN_ID} \ |
There was a problem hiding this comment.
The DOMAIN_ID env is likely not needed anymore, and could be hardcoded here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1243 and combines the domain node with the consensus node. Taurus domain node parameters are passed in as an env variable