Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains: AutoId domain runtime #2649

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Domains: AutoId domain runtime #2649

merged 3 commits into from
Apr 3, 2024

Conversation

vedhavyas
Copy link
Member

This PR introduces Domain Runtime for AutoId.
Client changes to run the Domain will be in the next PR

Code contributor checklist:

jfrank-summit
jfrank-summit previously approved these changes Mar 29, 2024
Copy link
Member

@jfrank-summit jfrank-summit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NingLin-P should review as well.

@vedhavyas vedhavyas force-pushed the auto-id-domain-runtime branch from ba5f1b5 to a254a67 Compare April 2, 2024 05:15
Base automatically changed from certificate_registry to main April 2, 2024 10:58
@vedhavyas vedhavyas dismissed jfrank-summit’s stale review April 2, 2024 10:58

The base branch was changed.

NingLin-P
NingLin-P previously approved these changes Apr 2, 2024
Copy link
Member

@NingLin-P NingLin-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense overall, a few some nits not related to this PR.

@vedhavyas vedhavyas force-pushed the auto-id-domain-runtime branch 2 times, most recently from f130c72 to 7cbd96a Compare April 3, 2024 08:04
@vedhavyas vedhavyas enabled auto-merge April 3, 2024 08:05
NingLin-P
NingLin-P previously approved these changes Apr 3, 2024
@vedhavyas vedhavyas added this pull request to the merge queue Apr 3, 2024
Merged via the queue into main with commit 6c357aa Apr 3, 2024
9 checks passed
@vedhavyas vedhavyas deleted the auto-id-domain-runtime branch April 3, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants