Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure to distribute the XDM fee regardless what the XDM execution result is #3395

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Ensure to distribute the XDM fee regardless what the XDM execution result is #3395

merged 1 commit into from
Feb 20, 2025

Conversation

NingLin-P
Copy link
Member

This PR ensures the XDM fee will be distributed to the operator set (or the farmer in case of consensus chain XDM) of the src/dst chain regardless what the XDM execution result is because:

  • The fee is already charged from the sender of the src chain
  • And the regardless what the result is, the processing of the XDM is finished

Code contributor checklist:

@NingLin-P NingLin-P added bug Something isn't working execution Subspace execution audit-P2 Medium audit priority labels Feb 19, 2025
@NingLin-P NingLin-P requested a review from teor2345 February 19, 2025 19:16
@NingLin-P NingLin-P requested a review from vedhavyas as a code owner February 19, 2025 19:16
teor2345
teor2345 approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@vedhavyas vedhavyas added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit 3701084 Feb 20, 2025
8 checks passed
@vedhavyas vedhavyas deleted the xdm-fee-fix branch February 20, 2025 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vedhavyas vedhavyas vedhavyas approved these changes

@teor2345 teor2345 teor2345 approved these changes

Assignees
No one assigned
Labels
audit-P2 Medium audit priority bug Something isn't working execution Subspace execution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NingLin-P @vedhavyas @teor2345