Add fallback decoding for the pallet-domains v3 storage migration #3407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
requested review from
NingLin-P,
vedhavyas and
nazar-pc
as code owners
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
teor2345
force-pushed
the
domain-registry-migration
branch
from
8b4a9ca to
ebce745
Compare
NingLin-P
reviewed
Feb 27, 2025
Comment on lines
+371
to
+372
| let mut domain_obj = | ||
| Pallet::<T>::domain_registry_fallback(domain_id).ok_or(Error::DomainNotFound)?; |
There was a problem hiding this comment.
The issue only shortly exists in runtime API calls on the block that contains the runtime upgrade.
While do_update_domain_allow_list (and also do_register_operator) is only called during block execution, where it is either using the old runtime and before migration or the new runtime and after the migration, it should not have the issue so not needed to use domain_registry_fallback.
Though it is also no harm to use domain_registry_fallback thus non-blocker.
vedhavyas
approved these changes
Feb 27, 2025
Comment on lines
+371
to
+372
| let mut domain_obj = | ||
| Pallet::<T>::domain_registry_fallback(domain_id).ok_or(Error::DomainNotFound)?; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes all production reads of the domain registry go through a new
domain_registry_fallback()method. This method first tries decoding as the v3 storage format, then tries v2 if that doesn't work.This is required so that code which queries the domain registry between runtime activation and storage migration still works.
Early writes to the storage using the v3 format are fine: they will be skipped as "corrupted" by the migration (which reads as v2), and be read as v3 correctly by the fallback decoder:
https://docs.rs/frame-support/latest/frame_support/storage/types/struct.StorageMap.html#method.translate_values
During local
devtesting, the upgrade block logs some spurious corrupted state warnings, then the next block imports without any warnings:Code contributor checklist: