migration: add case about migrate vm which have vmx-* cpu features #6139
+104
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliping
force-pushed
the
vmx
branch
2 times, most recently
from
a10cc7b to
5951bf9
Compare
XXX-303279 - [VM migration] migrate vm which have vmx-* cpu features Signed-off-by: lcheng <[email protected]>
smitterl
suggested changes
Mar 3, 2025
| cmd = "virsh domcapabilities |grep vmx- |wc -l" | ||
| ret = process.run(cmd, shell=True).stdout_text.strip() | ||
| if int(ret) == 0: | ||
| test.cancel("Please use the host with vmx-* cpu features to test.") |
There was a problem hiding this comment.
Honestly, I don't understand why we will have an explicit test for KVM on Intel migrations that is then canceled if run on a non-intel machine.
The test case is currently of Importance Medium in our system, so it looks like a nice to have. But in that case our existing migration tests already should cover this sufficiently. Not sure what I'm missing.
If this test case is really important enough to have this test script explicitly it should fail with test.error instead of being canceled which is more likely to be overlooked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XXX-303279 - [VM migration] migrate vm which have vmx-* cpu features
Test result:
(1/8) type_specific.io-github-autotest-libvirt.migration.migration_misc.migration_with_vmx_cpu_features.host_model.with_xml.p2p: STARTED
(1/8) type_specific.io-github-autotest-libvirt.migration.migration_misc.migration_with_vmx_cpu_features.host_model.with_xml.p2p: PASS (203.71 s)
(2/8) type_specific.io-github-autotest-libvirt.migration.migration_misc.migration_with_vmx_cpu_features.host_model.with_xml.non_p2p: STARTED
(2/8) type_specific.io-github-autotest-libvirt.migration.migration_misc.migration_with_vmx_cpu_features.host_model.with_xml.non_p2p: PASS (204.27 s)
(3/8) type_specific.io-github-autotest-libvirt.migration.migration_misc.migration_with_vmx_cpu_features.host_model.without_xml.p2p: STARTED
(3/8) type_specific.io-github-autotest-libvirt.migration.migration_misc.migration_with_vmx_cpu_features.host_model.without_xml.p2p: PASS (203.87 s)
(4/8) type_specific.io-github-autotest-libvirt.migration.migration_misc.migration_with_vmx_cpu_features.host_model.without_xml.non_p2p: STARTED
(4/8) type_specific.io-github-autotest-libvirt.migration.migration_misc.migration_with_vmx_cpu_features.host_model.without_xml.non_p2p: PASS (204.14 s)
(5/8) type_specific.io-github-autotest-libvirt.migration.migration_misc.migration_with_vmx_cpu_features.custom.with_xml.p2p: STARTED
(5/8) type_specific.io-github-autotest-libvirt.migration.migration_misc.migration_with_vmx_cpu_features.custom.with_xml.p2p: PASS (204.53 s)
(6/8) type_specific.io-github-autotest-libvirt.migration.migration_misc.migration_with_vmx_cpu_features.custom.with_xml.non_p2p: STARTED
(6/8) type_specific.io-github-autotest-libvirt.migration.migration_misc.migration_with_vmx_cpu_features.custom.with_xml.non_p2p: PASS (205.23 s)
(7/8) type_specific.io-github-autotest-libvirt.migration.migration_misc.migration_with_vmx_cpu_features.custom.without_xml.p2p: STARTED
(7/8) type_specific.io-github-autotest-libvirt.migration.migration_misc.migration_with_vmx_cpu_features.custom.without_xml.p2p: PASS (204.59 s)
(8/8) type_specific.io-github-autotest-libvirt.migration.migration_misc.migration_with_vmx_cpu_features.custom.without_xml.non_p2p: STARTED
(8/8) type_specific.io-github-autotest-libvirt.migration.migration_misc.migration_with_vmx_cpu_features.custom.without_xml.non_p2p: PASS (205.30 s)