virsh_detach_device_alias: enhancement for pci #6162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before fix: Skipped After fix: on same aarch64 host |
dzhengfy
force-pushed
the
fix_pci_hostdev
branch
from
1c0319d to
39d1851
Compare
Currently the cases are skipped in most time because below error: error: Failed to attach device from pci.xml error: internal error: Non-endpoint PCI devices cannot be assigned to guests This is because the incorrect pci device is used to attach to the vm. This fix is an enhancement to increase possiblities of finding the suitable pci device. Signed-off-by: Dan Zheng <[email protected]>
dzhengfy
force-pushed
the
fix_pci_hostdev
branch
from
39d1851 to
5c0cd6c
Compare
|
Tested on x86_64 libvirt-10.10.0: |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the cases are skipped in most time because below error:
error: Failed to attach device from pci.xml
error: internal error: Non-endpoint PCI devices cannot be assigned to guests
This is because the incorrect pci device is used to attach to the vm. This fix is an enhancement to increase possiblities of finding the suitable pci device.
Signed-off-by: Dan Zheng [email protected]