feat: add new traffic light detector artifacts download #5626
Conversation
Signed-off-by: badai-nguyen <[email protected]>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
LGTM
I checked this PR following https://github.com/autowarefoundation/autoware/tree/main/ansible/roles/artifacts.
And also checked this file is used by autoware_tensorrt_yolox like command ros2 launch autoware_tensorrt_yolox yolox_traffic_light_detector.launch.xml .
|
@youtalk @oguzkaganozt Could you review this PR as codeowner? If there is no any concern, I would like to merge this PR since the the related PR was merged. |
| @@ -269,6 +269,31 @@ | |||
| mode: "644" | |||
| checksum: sha256:3d93ca05f31b63424d7d7246a01a2365953705a0ed3323ba5b6fddd744a4bfea | |||
|
|
|||
| # traffic_light_detector model which referenced by tensorrt_yolox package | |||
There was a problem hiding this comment.
[imho]
We need to clearfy which tlr model will be downloaded in this role.
Do we have our new model name already? How about one-shot traffic_light_detector model?
There was a problem hiding this comment.
We need to clearfy which tlr model will be downloaded in this role.
all model listed here will be downloaded when setup autoware as default. The used model whill be selected by seting when launching autoware.
Do we have our new model name already? How about one-shot traffic_light_detector model?
- The current selected name is
yolox_s_car_ped_tl_detector_960_960_batch_1 - I think all current yolox only support
one-shotso it seems unnecessary?
There was a problem hiding this comment.
@YoshiRi do you hav another comments?
badai-nguyen
changed the title
Signed-off-by: badai-nguyen <[email protected]>
Description
How was this PR tested?
./setup-dev-env.shto download added artifactsNotes for reviewers
None.
Effects on system behavior
None.