feat(docker): add openadkit visualizer container #5742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguzkaganozt
requested review from
youtalk,
mitsudome-r and
xmfcx
as code owners
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
oguzkaganozt
changed the title
oguzkaganozt
added
type:containers
4 tasks
|
@youtalk @mitsudome-r Please review |
|
Could you describe how to use the visualizer container in README.md? |
youtalk
reviewed
Feb 7, 2025
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
oguzkaganozt
force-pushed
the
openadkit-visualizer
branch
from
1326e5e to
7ed6c16
Compare
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
youtalk
requested changes
Feb 10, 2025
Comment on lines
+83
to
+85
| *.args.BASE_IMAGE=${{ needs.load-env.outputs.base_image }} | ||
| *.args.AUTOWARE_BASE_IMAGE=${{ needs.load-env.outputs.autoware_base_image }} | ||
| *.args.AUTOWARE_BASE_CUDA_IMAGE=${{ needs.load-env.outputs.autoware_base_cuda_image }} |
There was a problem hiding this comment.
They aren't used in Dockerfile.visualizer.
Suggested change
| *.args.BASE_IMAGE=${{ needs.load-env.outputs.base_image }} | |
| *.args.AUTOWARE_BASE_IMAGE=${{ needs.load-env.outputs.autoware_base_image }} | |
| *.args.AUTOWARE_BASE_CUDA_IMAGE=${{ needs.load-env.outputs.autoware_base_cuda_image }} |
Comment on lines
+73
to
+75
| *.args.BASE_IMAGE=${{ needs.load-env.outputs.base_image }} | ||
| *.args.AUTOWARE_BASE_IMAGE=${{ needs.load-env.outputs.autoware_base_image }} | ||
| *.args.AUTOWARE_BASE_CUDA_IMAGE=${{ needs.load-env.outputs.autoware_base_cuda_image }} |
There was a problem hiding this comment.
Suggested change
| *.args.BASE_IMAGE=${{ needs.load-env.outputs.base_image }} | |
| *.args.AUTOWARE_BASE_IMAGE=${{ needs.load-env.outputs.autoware_base_image }} | |
| *.args.AUTOWARE_BASE_CUDA_IMAGE=${{ needs.load-env.outputs.autoware_base_cuda_image }} |
Comment on lines
+65
to
+66
| - name: Build 'autoware-tools' | ||
| uses: ./.github/actions/docker-build-and-push-tools |
There was a problem hiding this comment.
This job needs load-env and docker-build-and-push results.
Suggested change
| - name: Build 'autoware-tools' | |
| uses: ./.github/actions/docker-build-and-push-tools | |
| - name: Build 'autoware-tools' | |
| needs: [load-env, docker-build-and-push] | |
| uses: ./.github/actions/docker-build-and-push-tools |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To enable full development and deployment with distinct containers, a dedicated visualizer container will be beneficial. This container will include the RViz Plugins, ROS 2 message definitions both from autoware.universe and TierIV scenario simulator
Additionally, it will support VNC and NoVNC so users can visualize the RViz screen remotely.
How was this PR tested?
Same containers are used on two different demos and running well. Demos can be replicated through https://github.com/autowarefoundation/openadkit_demo.autoware/tree/planning-simviz/docker
Notes for reviewers
None.
Effects on system behavior
None.