chore: remove the support to auto-msgs. #115
Merged
+1
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtk8532704
requested review from
taikitanaka3,
TakaHoribe and
takayuki5168
as code owners
Signed-off-by: xtk8532704 <[email protected]>
Signed-off-by: xtk8532704 <[email protected]>
xtk8532704
force-pushed
the
remove-auto-msgs-dependency
branch
from
d3440bb
to
441d9af
Compare
takayuki5168
approved these changes
Sep 11, 2024
YoshihiroKogure
pushed a commit
to YoshihiroKogure/autoware_tools
that referenced
this pull request
Sep 26, 2024
* remove the support to auto-msgs. Signed-off-by: xtk8532704 <[email protected]> * style(pre-commit): autofix Signed-off-by: xtk8532704 <[email protected]> --------- Signed-off-by: xtk8532704 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to this discussion, This PR removes the support for old rosbags with auto-msgs.
Note that perception_reproducer can not be used directly for old rosbag now. In the future, we may update this tool to convert old rosbag for perception_reproducer.
Related links
Tests performed
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.