feat(autoware_lanelet2_divider): add lanelet2 divider tool #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Barış Zeren <[email protected]>
wenrir
reviewed
Oct 28, 2024
map/autoware_lanelet2_divider/autoware_lanelet2_divider/osmium_tool/osmium_tool.py
Outdated
Show resolved
Hide resolved
map/autoware_lanelet2_divider/autoware_lanelet2_divider/osmium_tool/osmium_tool.py
Outdated
Show resolved
Hide resolved
map/autoware_lanelet2_divider/autoware_lanelet2_divider/osmium_tool/osmium_tool.py
Outdated
Show resolved
Hide resolved
map/autoware_lanelet2_divider/autoware_lanelet2_divider/osmium_tool/osmium_tool.py
Outdated
Show resolved
Hide resolved
map/autoware_lanelet2_divider/autoware_lanelet2_divider/osmium_tool/osmium_tool.py
Outdated
Show resolved
Hide resolved
map/autoware_lanelet2_divider/autoware_lanelet2_divider/xml_tool/xml_tool.py
Outdated
Show resolved
Hide resolved
map/autoware_lanelet2_divider/autoware_lanelet2_divider/data_preperation/data_preperation.py
Outdated
Show resolved
Hide resolved
map/autoware_lanelet2_divider/autoware_lanelet2_divider/data_preperation/data_preperation.py
Outdated
Show resolved
Hide resolved
map/autoware_lanelet2_divider/autoware_lanelet2_divider/autoware_lanelet2_divider.py
Show resolved
Hide resolved
Signed-off-by: Barış Zeren <[email protected]>
Signed-off-by: Barış Zeren <[email protected]>
Signed-off-by: Barış Zeren <[email protected]>
Signed-off-by: Barış Zeren <[email protected]>
Signed-off-by: Barış Zeren <[email protected]>
Signed-off-by: Barış Zeren <[email protected]>
Signed-off-by: Barış Zeren <[email protected]>
Signed-off-by: Barış Zeren <[email protected]>
Signed-off-by: Barış Zeren <[email protected]>
Signed-off-by: Barış Zeren <[email protected]>
Signed-off-by: Barış Zeren <[email protected]>
Signed-off-by: Barış Zeren <[email protected]>
Signed-off-by: Barış Zeren <[email protected]>
|
@StepTurtle thank you for considering my review, I'm not able to resolve my own comments so please feel free to resolve/remove them. |
YamatoAndo
reviewed
Nov 19, 2024
| return True | ||
|
|
||
|
|
||
| def complete_missing_version_tag(input_osm_file_path: str): |
There was a problem hiding this comment.
What is the purpose of adding a version tag?
YamatoAndo
reviewed
Nov 19, 2024
| whole_map_xml = ET.parse(input_osm_file_path) | ||
| whole_map_root = whole_map_xml.getroot() | ||
|
|
||
| add_version = any(root_element != "version" for root_element in whole_map_root.attrib) |
There was a problem hiding this comment.
Why is it set to update as long as even one non-version element is found?
In this code, it updates even if there is a version tag, as long as there are other elements present.
YamatoAndo
reviewed
Nov 19, 2024
| add_version = any(root_element != "version" for root_element in whole_map_root.attrib) | ||
|
|
||
| if add_version: | ||
| whole_map_root.set("version", "0.6") |
There was a problem hiding this comment.
Why is the version fixed to 0.6?
I’d like to know the reason for choosing 0.6.
YamatoAndo
reviewed
Nov 19, 2024
| add_version = False | ||
| break | ||
| if add_version: | ||
| element.set("version", "1") |
There was a problem hiding this comment.
Why is the version fixed to 1?
And I’d like to understand the reason behind adding the version tag to each element. Why?
YamatoAndo
reviewed
Nov 19, 2024
| if add_version: | ||
| element.set("version", "1") | ||
|
|
||
| whole_map_xml.write(input_osm_file_path, encoding="utf-8", xml_declaration=True) |
There was a problem hiding this comment.
Please avoid directly modifying the input file.
Could you revise the implementation to create a new temporary file instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port lanelet2-map-tile-generator to
autoware_toolswith nameautoware_lanelet2_divider.cc. @ataparlar @YamatoAndo
Related links
Tests performed
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.