refactor(lalenet2_map_validator): divide map loading process #153
+158
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mamoru Sobue <[email protected]>
soblin
force-pushed
the
feat/add-map-load-validator
branch
from
b58aa63
to
5988d6b
Compare
soblin
requested review from
anhnv3991,
Motsu-san,
SakodaShintaro,
TaikiYamada4 and
YamatoAndo
as code owners
TaikiYamada4
requested changes
Nov 19, 2024
| { | ||
|
|
||
| std::pair<lanelet::LaneletMapPtr, std::vector<lanelet::validation::DetectedIssues>> | ||
| loadAndValidateMapLoad( |
There was a problem hiding this comment.
Is it necessary to have two loads in the function name here?
| replace_validator( | ||
| validator_config.command_line_config.validationConfig, validator_name))); | ||
| } | ||
| const auto prerequisite_issues = check_prerequisite_completion(validators, validator_name); |
There was a problem hiding this comment.
Could you add prerequisite_issues to total_issues?
I also want to display and write whether the prerequisites are met or not.
| const auto prerequisite_issues = check_prerequisite_completion(validators, validator_name); | ||
|
|
||
| const auto issues = | ||
| prerequisite_issues.empty() |
There was a problem hiding this comment.
I believe the condition is the opposite.
All validations that have correct prerequisites will not start and only PASSED results appear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current implementation tries to load the lanelet_map for each validation process which is inefficient and contaminates the report. With this PR, the map is loaded at first and then passed to each validation process.
Related links
Tests performed
unit test passes
Notes for reviewers
Interface changes
None
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.