Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving to a proper logging system #70

Open
2 of 43 tasks
icyflame opened this issue Sep 24, 2015 · 4 comments
Open
2 of 43 tasks

Moving to a proper logging system #70

icyflame opened this issue Sep 24, 2015 · 4 comments
Labels
long-term

Comments

@icyflame
Copy link
Member

http://wiki.ros.org/roscpp/Overview/Logging

http://wiki.ros.org/rospy/Overview/Logging

ROS has inbuilt support for Logging. We just have to use it.

We will have to port all of our code from existing cout, std::cout and print statements to ROS_INFO, ROS_DEBUG, etc.

It would be helpful if everyone quickly edited their projects and made these changes, and opened a PR. I would be able to merge them in fast.

Also, I would urge whoever is writing code from here on out to strictly use these instead of using stray cout and print statements in C++ and Python, respectively. (cc @kalyan-kumar , Barno and Priyank)

Opinions? @prudhvid @nevinvalsaraj @VishnuDuttSharma

cc @auviitkgp/developers @auviitkgp/embedded-team

Packages yet to port over to logging system

  • NqDVL /home/siddharth/ros_workspace/kraken_3.0/sensor_stack/NqDVL
  • Scripts /home/siddharth/ros_workspace/kraken_3.0/Scripts
  • SerialPort /home/siddharth/ros_workspace/kraken_3.0/hardware_stack/SerialPort
  • Telemetry /home/siddharth/ros_workspace/kraken_3.0/gui_stack/Telemetry
  • absolute_rpy_publisher /home/siddharth/ros_workspace/kraken_3.0/control_system_stack/absolute_rpy_publisher
  • actionmsg /home/siddharth/ros_workspace/kraken_3.0/vision_stack/actionmsg
  • blob /home/siddharth/ros_workspace/kraken_3.0/vision_stack/blob
  • bottomcam /home/siddharth/ros_workspace/kraken_3.0/vision_stack/camera/bottomcam
  • control_server /home/siddharth/ros_workspace/kraken_3.0/control_system_stack/control_server
  • controller_basic /home/siddharth/ros_workspace/kraken_3.0/control_system_stack/controller_basic
  • depth_sensor /home/siddharth/ros_workspace/kraken_3.0/sensor_stack/depth_sensor
  • frontcam /home/siddharth/ros_workspace/kraken_3.0/vision_stack/camera/frontcam
  • gui_control /home/siddharth/ros_workspace/kraken_3.0/gui_stack/gui_control
  • gui_controller_loader /home/siddharth/ros_workspace/kraken_3.0/gui_stack/gui_controller_loader
  • gui_template /home/siddharth/ros_workspace/kraken_3.0/gui_stack/gui_template
  • ip_msgs /home/siddharth/ros_workspace/kraken_3.0/msgs_stack/ip_msgs
  • joystick_control /home/siddharth/ros_workspace/kraken_3.0/simulator_stack/joystick_control
  • keyboard_control /home/siddharth/ros_workspace/kraken_3.0/control_system_stack/keyboard_control
  • kraken_msgs /home/siddharth/ros_workspace/kraken_3.0/msgs_stack/kraken_msgs
  • kraken_visualization /home/siddharth/ros_workspace/kraken_3.0/simulator_stack/kraken_visualization
  • manual_control /home/siddharth/ros_workspace/kraken_3.0/control_system_stack/manual_control
  • mission_planner /home/siddharth/ros_workspace/kraken_3.0/mission_planner_stack/mission_planner
  • nqDVL /home/siddharth/ros_workspace/kraken_3.0/sensor_stack/nqDVL
  • pose_server /home/siddharth/ros_workspace/kraken_3.0/mission_planner_stack/pose_server
  • pose_server_python /home/siddharth/ros_workspace/kraken_3.0/mission_planner_stack/pose_server_python
  • premap /home/siddharth/ros_workspace/kraken_3.0/mission_planner_stack/premap
  • resources /home/siddharth/ros_workspace/kraken_3.0/resources
  • seabotix /home/siddharth/ros_workspace/kraken_3.0/sensor_stack/seabotix
  • simulator_physics_model /home/siddharth/ros_workspace/kraken_3.0/simulator_stack/simulator_physics_model
  • simulator_to_kmsgs /home/siddharth/ros_workspace/kraken_3.0/simulator_stack/simulator_to_kmsgs
  • simulator_to_navpose /home/siddharth/ros_workspace/kraken_3.0/simulator_stack/simulator_to_navpose
  • sparton /home/siddharth/ros_workspace/kraken_3.0/sensor_stack/sparton
  • task_buoy /home/siddharth/ros_workspace/kraken_3.0/vision_stack/task_buoy
  • task_marker /home/siddharth/ros_workspace/kraken_3.0/vision_stack/task_marker
  • thruster_converter /home/siddharth/ros_workspace/kraken_3.0/control_system_stack/thruster_converter
  • thruster_force_converter /home/siddharth/ros_workspace/kraken_3.0/simulator_stack/thruster_force_converter
  • tracks_imu /home/siddharth/ros_workspace/kraken_3.0/sensor_stack/tracks_imu
  • trax /home/siddharth/ros_workspace/kraken_3.0/sensor_stack/trax
  • vgateclient /home/siddharth/ros_workspace/kraken_3.0/vision_stack/validationgate/vgateclient
  • vgatedetect /home/siddharth/ros_workspace/kraken_3.0/vision_stack/validationgate/vgatedetect
  • vgateserver /home/siddharth/ros_workspace/kraken_3.0/vision_stack/validationgate/vgateserver
  • videoread /home/siddharth/ros_workspace/kraken_3.0/vision_stack/camera/videoread
  • vision_gui /home/siddharth/ros_workspace/kraken_3.0/vision_stack/vision_gui
@icyflame
Copy link
Member Author

update regarding log levels

  • Print all debug messages using the rospy.logdebug or the ROS_DEBUG function.
  • Also, if the CLI argument --debug or --verbose is passed to the executable call statement, then initialise the node with loglevel as DEBUG, so that the /rosout topic will become the central place to recieve all log information.

cc @auviitkgp/developers @auviitkgp/embedded-team @auviitkgp/maintainers

icyflame added a commit to icyflame/kraken_3.0 that referenced this issue Sep 26, 2015
@icyflame
Fix the absolute RPY Publisher to improve logging
63df1f3 
Related to auviitkgp#70

Signed-off-by: Siddharth Kannan <[email protected]>
@icyflame icyflame mentioned this issue Sep 28, 2015
Closed
icyflame added a commit to icyflame/kraken_3.0 that referenced this issue Oct 2, 2015
@icyflame
Fix the absolute RPY Publisher to improve logging
728eb9d 
Related to auviitkgp#70

Signed-off-by: Siddharth Kannan <[email protected]>
icyflame added a commit to icyflame/kraken_3.0 that referenced this issue Oct 2, 2015
@icyflame
Fix the absolute_rpy_publisher to use tools
168940a 
- Tools is a library inside the resources/ package that can be used
  for functions that are required across the repository.

Related to auviitkgp#70

Freeze style of implementing logging in Python.

Signed-off-by: Siddharth Kannan <[email protected]>
icyflame added a commit to icyflame/kraken_3.0 that referenced this issue Oct 2, 2015
@icyflame
Complete logging intergration: thruster_converter.
857f5ab 
- Use this as a reference to work with other CPP packages.

Related to auviitkgp#70

Signed-off-by: Siddharth Kannan <[email protected]>
@icyflame
Copy link
Member Author

icyflame commented Oct 2, 2015

I have abstracted the verbose tag code as a function in the resources package, under the tools namespace for CPP and under resource.tools for Python.

Refer to icyflame@857f5ab for CPP.

Refer to icyflame@168940a for Python.

cc @auviitkgp/developers @auviitkgp/embedded-team

@icyflame icyflame mentioned this issue Oct 2, 2015
Merged
icyflame added a commit that referenced this issue Oct 2, 2015
@icyflame
Merge pull request #80 from icyflame/fix-logging
e226253 
Fix logging inside Absolute RPY Publisher and Thruster Converter

Moves towards fixing #70 

This PR also creates a standard for using the `tools` functions to optimise this process. Read more about this here: #70 (comment)
@prudhvid
Copy link
Contributor

prudhvid commented Oct 2, 2015

@icyflame 👍 nice work. And also assign this task to others. You don't do the shift all alone.
@kalyan-kumar @ManviG @pranaypratyush you take some of the other packages and shift them to the new logging system.

@icyflame icyflame mentioned this issue Oct 14, 2015
Closed
@icyflame
Copy link
Member Author

References for C++ and Python

icyflame added a commit to icyflame/kraken_3.0 that referenced this issue Nov 4, 2015
@icyflame
Fix the absolute RPY Publisher to improve logging
a452e04 
Related to auviitkgp#70

Signed-off-by: Siddharth Kannan <[email protected]>
icyflame added a commit to icyflame/kraken_3.0 that referenced this issue Nov 4, 2015
@icyflame
Fix the absolute_rpy_publisher to use tools
5bba55f 
- Tools is a library inside the resources/ package that can be used
  for functions that are required across the repository.

Related to auviitkgp#70

Freeze style of implementing logging in Python.

Signed-off-by: Siddharth Kannan <[email protected]>
icyflame added a commit to icyflame/kraken_3.0 that referenced this issue Nov 4, 2015
@icyflame
Complete logging intergration: thruster_converter.
651c2a8 
- Use this as a reference to work with other CPP packages.

Related to auviitkgp#70

Signed-off-by: Siddharth Kannan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
long-term
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@icyflame @prudhvid