Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Yaw Action Server Architecture #83

Closed
wants to merge 7 commits into from

Conversation

aniket11bh
Copy link
Contributor

  • Action server completed for sending goal.
  • Package all_controllers to include all types of controllers in future
  • Removed clash of controllerResult.msg file.

TODO :

  • Shift fuzzyControl.py file to manual_control package.

- TODO : make it working for change in yaw by large angles, in -ve side.

Signed-off-by: Aniket Bhushan <[email protected]>
pub_thrusters6.publish(thruster6Data)

# Debug messages
# rospy.logdebug("--------")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aniket11bh You don't need to comment out logdebug lines. Uncomment these lines, so that if the node is run in verbose mode then we will be able to see these lines as well. Otherwise these lines won't show up.

- Do `verbose-code-style` in main.py
- Action server communication named explicitly
- Change Action server node name to `setyaw-action-server`
- Do loginfo for Error as feedback only in client

Signed-off-by: Aniket Bhushan <[email protected]>
@icyflame icyflame changed the title Set yaw server Set Yaw Action Server Architecture Oct 19, 2015
@icyflame
Copy link
Member

Code works as expected. The graphing inside rqt_plot still does not work. @aniket11bh is finding solutions to this. We will be able to merge this PR after that change.

- All the messages initialized inside the class
- All the pub and sub are inside the constructor

TODO : 
- Need to terminate the process of achieving a goal when, client decides.

Signed-off-by: Aniket Bhushan <[email protected]>
@icyflame
Copy link
Member

LGTM

@aniket11bh
Copy link
Contributor Author

As one of the uses of actionlib package is that if the service takes a long time to execute, the user might want the ability to cancel the request during execution or get periodic feedback about how the request is progressing.
But it is not working right now, (as these lines are commented out). And the problem is that they are not working simultaneously with our present code :

if self._as.is_preempt_requested():
        rospy.loginfo('%s: Preempted' % self._action_name)
        self._as.set_preempted()
        success = False
        break

@icyflame
Copy link
Member

@aniket11bh So, why don't you uncomment it and see what the problem is?

I remember that we had extensively debugged this using print statements and had hit a wall, a few days back.

I don't understand why it is not working, maybe we are missing something.

@@ -0,0 +1,75 @@
f_ssets = [[ # error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can re-write this code later so as to use ROS' Parameter server to get these parameters.

The values are defined in a yaml file such as this one config/dynamics_g500.yaml and then accessed using a function in Python like getParams

Signed-off-by: Aniket Bhushan <[email protected]>
@icyflame
Copy link
Member

@aniket11bh

Checked this on my machine, It works fine for most part. One of the problems that is still there is that on pressing Ctrl+C inside the client script, it says You pressed Ctrl+C but doesn't preempt the goal. This is not that big of an issue, so, I am going to go ahead and merge this PR in, but let's work on solving this as soon as the next dev cycle begins.

@auviitkgp auviitkgp locked and limited conversation to collaborators Oct 30, 2015
@auviitkgp auviitkgp unlocked this conversation Oct 30, 2015
@icyflame
Copy link
Member

Merged in 051180f

@icyflame icyflame closed this Oct 30, 2015
kalyan-kumar pushed a commit to kalyan-kumar/kraken_3.0 that referenced this pull request Oct 30, 2015
- Add the setyaw package that uses one of the controllers inside the
  all_controllers package to control the heading of the vehicle.
- Lead to the creation of auviitkgp#87

Great work by @aniket11bh and @kshitijgoel007 ! 😄

FIXES auviitkgp#83

Signed-off-by: Siddharth Kannan <[email protected]>
icyflame added a commit to icyflame/kraken_3.0 that referenced this pull request Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants