-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Yaw Action Server Architecture #83
Conversation
- TODO : make it working for change in yaw by large angles, in -ve side. Signed-off-by: Aniket Bhushan <[email protected]>
pub_thrusters6.publish(thruster6Data) | ||
|
||
# Debug messages | ||
# rospy.logdebug("--------") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aniket11bh You don't need to comment out logdebug
lines. Uncomment these lines, so that if the node is run in verbose
mode then we will be able to see these lines as well. Otherwise these lines won't show up.
- Do `verbose-code-style` in main.py - Action server communication named explicitly - Change Action server node name to `setyaw-action-server` - Do loginfo for Error as feedback only in client Signed-off-by: Aniket Bhushan <[email protected]>
Signed-off-by: Aniket Bhushan <[email protected]>
Code works as expected. The graphing inside |
Signed-off-by: Aniket Bhushan <[email protected]>
- All the messages initialized inside the class - All the pub and sub are inside the constructor TODO : - Need to terminate the process of achieving a goal when, client decides. Signed-off-by: Aniket Bhushan <[email protected]>
Signed-off-by: Aniket Bhushan <[email protected]>
LGTM |
As one of the uses of if self._as.is_preempt_requested():
rospy.loginfo('%s: Preempted' % self._action_name)
self._as.set_preempted()
success = False
break |
@aniket11bh So, why don't you uncomment it and see what the problem is? I remember that we had extensively debugged this using I don't understand why it is not working, maybe we are missing something. |
@@ -0,0 +1,75 @@ | |||
f_ssets = [[ # error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can re-write this code later so as to use ROS' Parameter server to get these parameters.
The values are defined in a yaml
file such as this one config/dynamics_g500.yaml and then accessed using a function in Python like getParams
Signed-off-by: Aniket Bhushan <[email protected]>
Checked this on my machine, It works fine for most part. One of the problems that is still there is that on pressing |
Merged in 051180f |
- Add the setyaw package that uses one of the controllers inside the all_controllers package to control the heading of the vehicle. - Lead to the creation of auviitkgp#87 Great work by @aniket11bh and @kshitijgoel007 ! 😄 FIXES auviitkgp#83 Signed-off-by: Siddharth Kannan <[email protected]>
Signed-off-by: Siddharth Kannan <[email protected]>
all_controllers
to include all types of controllers in futurecontrollerResult.msg
file.TODO :
fuzzyControl.py
file tomanual_control
package.