Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant vote processing of piggybacked vote #62

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Conversation

yacovm
Copy link
Collaborator

@yacovm yacovm commented Jan 28, 2025

Votes from the block proposer are piggybacked by the block message.

The current code verifies them twice, so I removed the redundant processing.

samliok
samliok previously approved these changes Jan 28, 2025
@yacovm yacovm marked this pull request as draft January 28, 2025 23:27
@yacovm yacovm marked this pull request as ready for review January 28, 2025 23:42
@yacovm yacovm changed the title Pass correct nodeID to handleVoteMessage when using the vote piggybacked by the proposal Remove redundant vote processing of piggybacked vote Jan 28, 2025
Votes from the block proposer are piggybacked by the block message.
The current code verifies them twice, so I removed the redundant processing.

Signed-off-by: Yacov Manevich <[email protected]>
@yacovm yacovm merged commit 961ef24 into main Jan 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants