vms: Migrate timestampvm
#2493
Closed
vms: Migrate timestampvm
#2493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
force-pushed
the
tmpnet-subnets
branch
3 times, most recently
from
d24f48e to
4e17abf
Compare
marun
force-pushed
the
migrate-timestampvm
branch
2 times, most recently
from
8f54419 to
6991ec7
Compare
marun
force-pushed
the
tmpnet-subnets
branch
2 times, most recently
from
85776ec to
6b65ce9
Compare
marun
force-pushed
the
migrate-timestampvm
branch
from
6991ec7 to
4c301c3
Compare
marun
force-pushed
the
tmpnet-subnets
branch
from
68b5580 to
d55d1d0
Compare
marun
force-pushed
the
migrate-timestampvm
branch
from
4c301c3 to
b763418
Compare
marun
force-pushed
the
tmpnet-subnets
branch
3 times, most recently
from
9e492ad to
677455a
Compare
marun
force-pushed
the
migrate-timestampvm
branch
from
b763418 to
5c0505b
Compare
marun
force-pushed
the
tmpnet-subnets
branch
from
677455a to
8bdc55f
Compare
marun
force-pushed
the
migrate-timestampvm
branch
2 times, most recently
from
da261e5 to
018d8ac
Compare
marun
force-pushed
the
tmpnet-subnets
branch
from
8bdc55f to
7667986
Compare
marun
force-pushed
the
migrate-timestampvm
branch
from
018d8ac to
f7028ba
Compare
marun
force-pushed
the
tmpnet-subnets
branch
from
7667986 to
d7d4751
Compare
marun
force-pushed
the
tmpnet-subnets
branch
from
d7d4751 to
08790e7
Compare
marun
force-pushed
the
migrate-timestampvm
branch
from
f7028ba to
2e86d43
Compare
marun
force-pushed
the
tmpnet-subnets
branch
from
08790e7 to
e8397e6
Compare
marun
force-pushed
the
migrate-timestampvm
branch
from
2e86d43 to
df5f563
Compare
marun
force-pushed
the
tmpnet-subnets
branch
from
e8397e6 to
74fdef2
Compare
marun
force-pushed
the
migrate-timestampvm
branch
from
df5f563 to
310de30
Compare
marun
force-pushed
the
tmpnet-subnets
branch
from
ef0af9c to
9187355
Compare
marun
force-pushed
the
tmpnet-xsvm-cleanup
branch
from
ea75c47 to
643552d
Compare
- update tmpnet.ReadFlagsMap to avoid returning an unnecessary pointer - add tmpnet.InterfaceToFlagsMap helper to simplify conversion of subnet configuration to a FlagsMap for nicer serialization - update tmpnet.NewNodes to initialize tls and signing keys so that nodes returned by this method can be used to extract the validator IDs for a subnet - switch tmpnet.Chain.Genesis back to a byte array. A previous attempt to improve the readability of tmpnet subnet configuration by converting to FlagsMap ignored that genesis byte format is VM-specific. - switch tmpnet.Chain.Config back to a string. A previous attempt to improve the readability of tmpnet subnet configuration by converting to FlagsMap ignored that VMs need to be able to specify their exact configuration.
marun
force-pushed
the
tmpnet-xsvm-cleanup
branch
from
643552d to
be84fa9
Compare
Co-authored-by: Aaron Buchwald <[email protected]> Co-authored-by: Arda Kayagil <[email protected]> Co-authored-by: Ceyhun Onur <[email protected]> Co-authored-by: Connor Bode <[email protected]> Co-authored-by: Dan Sover <[email protected]> Co-authored-by: Felipe Madero <[email protected]> Co-authored-by: Gabriel Cardona <[email protected]> Co-authored-by: Grant Haywood <[email protected]> Co-authored-by: Gyuho Lee <[email protected]> Co-authored-by: Patrick O'Grady <[email protected]> Co-authored-by: Sam Batschelet <[email protected]> Co-authored-by: Sam Liokumovich <[email protected]> Co-authored-by: Stephen Buttolph <[email protected]>
marun
force-pushed
the
migrate-timestampvm
branch
from
696adec to
c6dc756
Compare
marun
force-pushed
the
tmpnet-xsvm-cleanup
branch
from
b7c8292 to
7415609
Compare
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
|
Not sure this has value. Closing for now, will leave branch in case we want to pick it up in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating timestampvm is in support of factoring out common elements of the example VMs (the other being xsvm) as a precursor to factoring out common elements of coreth and subnet-evm in the interests of reducing the maintenance burden our EVMs represent.
TODO