e2e: Switch to the tmpnet fixture
#1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
force-pushed
the
e2e-warp-to-tmpnet
branch
from
36fe1e8 to
cfb3b4b
Compare
marun
changed the title
e2e: Switch warp test to use tmpnet fixture
marun
force-pushed
the
e2e-warp-to-tmpnet
branch
15 times, most recently
from
3a3748a to
028c479
Compare
marun
changed the title
e2e: Switch warp test to use tmpnet fixturee2e: Switch from ANR to the tmpnet fixture
marun
force-pushed
the
e2e-warp-to-tmpnet
branch
from
028c479 to
7f93cec
Compare
marun
changed the title
e2e: Switch from ANR to the tmpnet fixturee2e: Switch to the tmpnet fixture
marun
force-pushed
the
e2e-warp-to-tmpnet
branch
from
7f93cec to
03ee1fe
Compare
marun
force-pushed
the
e2e-warp-to-tmpnet
branch
3 times, most recently
from
d1d7480 to
db6bf98
Compare
2 tasks
marun
force-pushed
the
e2e-warp-to-tmpnet
branch
3 times, most recently
from
a9d3ac5 to
ceada0f
Compare
ceyonur
reviewed
Feb 26, 2024
tests/load/load_test.go
Outdated
| nodes, | ||
| tmpnet.FlagsMap{ | ||
| // The default tmpnet log level (info/debug) induces too much overhead for load testing. | ||
| config.LogDisplayLevelKey: "error", |
There was a problem hiding this comment.
Not critical but would be good if we can at least run this with info.
I've tested it to see if works with info here https://github.com/ava-labs/subnet-evm/pull/1104/files
There was a problem hiding this comment.
This is for stdout, which is ignored for the purposes of a tmpnet network.
There was a problem hiding this comment.
Really the default for tmpnet should be error too, but I'll handle that separately since I don't want to require another update to avalanchego to get this PR mergeable.
Edit: Maybe it should actually be --log-display-level=off if we're ignoring it?
darioush
previously approved these changes
Feb 26, 2024
darioush
previously approved these changes
Feb 26, 2024
ceyonur
previously approved these changes
Feb 27, 2024
marun
force-pushed
the
e2e-warp-to-tmpnet
branch
from
1a6fd85 to
a3d799c
Compare
|
Disabled stdout logging |
ceyonur
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the use of ANR in the warp and load testing e2e suites with the tmpnet fixture from avalanchego.
TODO
tmpnet: Add support for subnets avalanchego#2492