Format Only Changes

[SentryMan]

• sorts Context/Jex members
• adds auto-formatter
• format code with the google java style palantir-style

[rbygrave]

format code with the google java style

I'm unconvinced by this.

[SentryMan]

I'm unconvinced by this.

Is there any particular reason?

Pros:

• It all but eliminates "diff noise" due to whitespace and other insignificant formatting choices, allowing contributors/reviewers to focus on logic and functionality.
• Enforces code consistency no matter what tool you use to write code
• By automating formatting, contributors are less likely to introduce manual formatting mistakes.

Cons:

• Removes the ability to do any 'special-case' formatting where an alternate format would make code more readable in some cases.

[rbygrave]

Is there any particular reason?

For me, it fails aesthetically in too many common cases with too much indentation (double and quadrupedal indentation) and line breaking.

There are formatters that don't aesthetically fail as much as google java style / basically closer to IntelliJ style.

[SentryMan]

do you have one in mind that I can setup automatic formatting with?

[SentryMan]

For me I couldn't care less about any particular code style, it's just that a standard format that can be enforced automatically makes contribution/reviewing easier.

[SentryMan]

what do you think about https://github.com/palantir/palantir-java-format

[rbygrave]

what do you think about https://github.com/palantir/palantir-java-format

I have been trying it out actually, but yes it does kinda suck in some DSL cases [e.g. ebean query bean queries] so I'm not 100% sold on it. Still looking.

[SentryMan]

it does kinda suck in some DSL cases [e.g. ebean query bean queries]

okay, but are those DSL cases in this repo/pr? I'm not talking about changing what you use for application development.