Merge pull request #6205 from avalonmediasystem/delete_checkouts

Delete checkouts when associated media object is deleted

app/models/media_object.rb

@@ -192,6 +192,7 @@ def destroy
     # avoid calling destroy on each section since it calls save on parent media object
     self.sections.each(&:delete)
     Bookmark.where(document_id: self.id).destroy_all
+    Checkout.where(media_object_id: self.id).destroy_all
     super
   end
 

lib/tasks/avalon.rake

@@ -64,6 +64,12 @@ namespace :avalon do
     ActiveEncode::EngineAdapters::FfmpegAdapter.remove_old_files!(options)
   end
 
+  desc 'clean out orphaned checkout records'
+  task checkout_record_cleanup: :environment do
+    orphans = Checkout.all.select { |co| !MediaObject.exists?(co.media_object_id) }
+    orphans.destroy_all
+  end
+
   namespace :services do
     services = ["jetty", "felix", "delayed_job"]
     desc "Start Avalon's dependent services"

spec/models/media_object_spec.rb

@@ -512,6 +512,7 @@
   describe '#destroy' do
     let(:media_object) { FactoryBot.create(:media_object, :with_master_file) }
     let(:master_file) { media_object.sections.first }
+    let!(:checkouts) { FactoryBot.create_list(:checkout, 3, media_object_id: media_object.id) }
 
     before do
       allow(master_file).to receive(:stop_processing!)
@@ -531,6 +532,10 @@
       expect { media_object.destroy }.to change { MasterFile.count }.from(2).to(0)
       expect(MediaObject.exists?(media_object.id)).to be_falsey
     end
+
+    it 'destroys related checkouts' do
+      expect { media_object.destroy }.to change { Checkout.where(media_object_id: media_object.id).count }.from(3).to(0)
+    end
   end
 
   context "dependent properties" do