Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python version cfg #25

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Fix python version cfg #25

merged 2 commits into from
Jul 23, 2021

Conversation

pejter
Copy link
Contributor

@pejter pejter commented Jul 22, 2021

No description provided.

@pejter
Copy link
Contributor Author

pejter commented Jul 22, 2021

Fixed the clippy warnings.

@aviramha
Copy link
Owner

image
We need to follow those instructions to have the supplemented PyO3 cfgs.

@aviramha aviramha self-assigned this Jul 22, 2021
@aviramha aviramha self-requested a review July 22, 2021 21:05
@pejter
Copy link
Contributor Author

pejter commented Jul 22, 2021

So why does it work without it at the moment? If the dependency isn't present and the flags are missing then something should fail, right? I tested the 3.6 version locally and it does indeed fail at import, so perhaps there should be a very basic python-level test suite in place to verify the API?

@aviramha
Copy link
Owner

aviramha commented Jul 23, 2021

@pejter It is odd. I'm working on adding a test to verify declaration works as desired.
#27

@aviramha
Copy link
Owner

aviramha commented Jul 23, 2021

It seems that it does fail. Your changes should fix it.
I took the liberty to do the build.rs changes, hope that's okay :)

change minimum for fastcall to py3.8
@aviramha aviramha merged commit b689f0b into aviramha:master Jul 23, 2021
@aviramha
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants