Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RPM build dependencies #65

Merged
merged 3 commits into from
Jun 18, 2015
Merged

Added RPM build dependencies #65

merged 3 commits into from
Jun 18, 2015

Conversation

jaredmorgs
Copy link
Contributor

Based on our chat today with @mojavelinux, I've made a minor change to the getting started. Hope it hits the mark, mate. :D

Based on our chat today with @mojavelinux, I've made a minor change to the getting started. Hope it hits the mark, mate. :D
@mojavelinux
Copy link
Member

Excellent! Such vital information.


Additionally, run the following command to install all dependencies required by Nokogiri.

$ sudo yum install rubyjems-nokogiri gcc gcc-c++ ruby-devel zlib-devel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you've got a "j" where you want a "g" in rubyjems-nokogiri. Can you update?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure that gcc is included in the development-tools group, so I think that one can be safely removed from this command.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the correct package name for Nokogiri is rubygem-nokogiri (notice I dropped the "s").

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In total, I think the command should be:

$ sudo yum install ruby-devel libxslt-devel gcc-c++

libxslt-devel pulls in libxml2-devel and zlib-devel, which allows Nokogiri to be installed. We don't actually need the rubygem-nokogiri package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to use the command recommended after creating a new site, we should add "rake" to this list.

$ sudo yum install rake ruby-devel libxslt-devel gcc-c++

Added feedback from @mojavelinux and corrected yum commands as prescribed.
@jaredmorgs
Copy link
Contributor Author

Things are looking ready to roll now, @mojavelinux . Thanks for the feedback.

@mojavelinux
Copy link
Member

👍


Additionally, run the following command to install all dependencies required by Awestruct.

$ sudo sudo yum install -y rake ruby-devel libxslt-devel gcc-c++
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh. "sudo" is written twice here. Otherwise, looks great!

Yo dawg: I heard you like to sudo. So I put a sudo in your sudo so you can superuser while you superuser.
@jaredmorgs
Copy link
Contributor Author

sudo sudo is now removed. I need to stop doing these edits at night. :(

@mojavelinux
Copy link
Member

Looks great to me! @LightGuard want to review and merge?

LightGuard added a commit that referenced this pull request Jun 18, 2015
Added RPM build dependencies
@LightGuard LightGuard merged commit bc04440 into awestruct:master Jun 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants