fix: Add cognito-idp:AdminCreateUser for mobileclient tests #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooj2
approved these changes
May 19, 2020
| @@ -353,7 +350,9 @@ def create_custom_auth_lambda_configuration( | |||
|
|
|||
| def update_common_stack_with_test_policy(self, common_stack: CommonStack): | |||
| stack_policy = aws_iam.PolicyStatement( | |||
| effect=aws_iam.Effect.ALLOW, actions=["cognito-identity:*"], resources=["*"] | |||
| effect=aws_iam.Effect.ALLOW, | |||
| actions=["cognito-identity:*", "cognito-idp:AdminCreateUser"], | |||
There was a problem hiding this comment.
I know this is carry over from how things worked before, but, is there any way to reduce blast radius by only allowing specific actions on cognito-identity?
There was a problem hiding this comment.
In this specific case, it turns out this action statement is redundant: we already declare cognito-identity:* in another area of the stack.
More generally, it's challenging to limit cognito-identity because the tests themselves use many admin functions to do resource setup & tear down for the tests themselves. I've added a backlog item to reduce scope on that and other permissions: #38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
AdminCreateUserto mobileclient user pool for integ tests. Fixes linting & formatting.Consumed by aws-amplify/aws-sdk-ios#2612
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.