feat!: Update node to 22 #14079
Draft
feat!: Update node to 22 #14079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolk
commented
Jan 24, 2025
| cwd: process.cwd(), | ||
| env: process.env, | ||
| stdio: 'inherit', | ||
| shell: isWin ? true : undefined, |
There was a problem hiding this comment.
Using shell: true is required in latest versions of node (all LTS lines) to run .cmd files on Windows.
| @@ -152,7 +153,7 @@ const createCustomResource = ( | |||
| ): void => { | |||
| const triggerCode = fs.readFileSync(authTriggerAssetFilePath, 'utf-8'); | |||
| const authTriggerFn = new lambda.Function(stack, 'authTriggerFn', { | |||
| runtime: lambda.Runtime.NODEJS_18_X, | |||
| runtime: new lambda.Runtime('nodejs22.x', RuntimeFamily.NODEJS, { supportsInlineCode: true }), | |||
There was a problem hiding this comment.
Node 22 is not available as enum in currently used version of CDK.
This is a workaround recommended here https://github.com/aws/aws-cdk/blob/8b472fc5a68c2c83349dbfc11fa502f08d0bd5c8/packages/aws-cdk-lib/aws-lambda/lib/runtime.ts#L50-L51 .
| // as they bundle AWS SDK v2. This mechanism isn't viable to upgrade to nodejs18.x | ||
| // as that version bundles AWS SDK v3 which is not compatible. | ||
| const lambdaRuntimeVersion = 'nodejs16.x'; | ||
| const previousLambdaRuntimeVersions = ['nodejs18.x']; |
There was a problem hiding this comment.
the pre-18 runtimes are long gone. So we can move the baseline in this file at this point.
Comment on lines
+13
to
+24
| const fileContents = fs.readFileSync(awsExportsPath, 'utf-8'); | ||
| // transpile the file contents to CommonJS | ||
| const { code } = transformSync(fileContents, { | ||
| plugins: [babelTransformEsmToCjs], | ||
| configFile: false, | ||
| babelrc: false, | ||
| }); | ||
| const mod = new Module('aws-exports.js'); | ||
| // @ts-expect-error This is private api. | ||
| mod._compile(code, 'aws-exports.js'); | ||
| mod.paths = [projectRoot]; | ||
| return mod.exports; |
There was a problem hiding this comment.
The esm 3rd party package that was used here before causes V8 to crash with segfault.
I have replaced this with solution borrowed from here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR:
pkg/pkg-fetchwithyao-pkg/pkg. Theyao-pkg/pkgis actively developed fork of archivedpkgproject.node22binaries when producing CLI binaryCompanion PR: #14078
Issue #, if available
Description of how you validated changes
Obtained passing e2e run.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.