fix(auth): update FetchDevicesOutput output type to include name attribute #14186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinkumar6
requested review from
sktimalsina,
cshfang,
HuiSF and
pranavosu
as code owners
ashwinkumar6
commented
Feb 3, 2025
| @@ -81,7 +81,23 @@ describe('fetchDevices', () => { | |||
| }); | |||
|
|
|||
| it('should fetch devices and parse client response correctly', async () => { | |||
| expect(await fetchDevices()).toEqual([apiOutputDevice]); | |||
| const { | |||
There was a problem hiding this comment.
we should probably update all API unit tests to
- use a wrapper to catch input type issues
- destructure result object to catch output type issues
(reference)
HuiSF
approved these changes
Feb 4, 2025
| @@ -77,7 +77,7 @@ const parseDevicesResponse = async ( | |||
| {}, | |||
| ); | |||
|
|
|||
| return { | |||
| const result: AWSAuthDevice = { | |||
There was a problem hiding this comment.
nit: could be
devices.map<AWSAuthDevice>()There was a problem hiding this comment.
tried this as well but TS only enforces mandatory keys
cshfang
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
nameattribute to fetchDevices API's return type FetchDevicesOutputIssue #, if available
#14178
Description of how you validated changes
Before
After
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.