fix(core): build in CookieSerializeOptions def #14213
Merged
+100
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuiSF
requested review from
sktimalsina,
cshfang,
pranavosu and
a team
as code owners
HuiSF
force-pushed
the
hui/fix/core/cookie-type
branch
from
278f1db to
b07145e
Compare
HuiSF
changed the title
HuiSF
force-pushed
the
hui/fix/core/cookie-type
branch
from
b07145e to
cb904e7
Compare
HuiSF
changed the title
cshfang
previously approved these changes
Feb 14, 2025
jjarvisp
previously approved these changes
Feb 14, 2025
ashwinkumar6
previously approved these changes
Feb 14, 2025
ashika112
previously approved these changes
Feb 14, 2025
HuiSF
dismissed stale reviews from ashika112, ashwinkumar6, jjarvisp, and cshfang
via
0fa8769
ashika112
previously approved these changes
Feb 14, 2025
cshfang
previously approved these changes
Feb 14, 2025
jjarvisp
previously approved these changes
Feb 14, 2025
ashwinkumar6
previously approved these changes
Feb 14, 2025
HuiSF
dismissed stale reviews from ashwinkumar6, jjarvisp, cshfang, and ashika112
The base branch was changed.
HuiSF
force-pushed
the
hui/fix/core/cookie-type
branch
from
0fa8769 to
11f0a69
Compare
HuiSF
changed the title
jjarvisp
approved these changes
Feb 18, 2025
ashwinkumar6
approved these changes
Feb 18, 2025
ashika112
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Remove the
cookieand@types/cookie(has been deprecated) dependencies and build-in theCookieSerializeOptionstype definition.Issue #, if available
#14212
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.