-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(s3): cleanup file cache after mpu task is cancelled #5128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atierian
temporarily deployed
to
IntegrationTest
December 15, 2023 17:12 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
December 15, 2023 17:12 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
December 15, 2023 17:12 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
December 15, 2023 17:12 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
December 15, 2023 17:12 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
December 15, 2023 17:12 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
December 15, 2023 17:12 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
December 15, 2023 17:12 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
December 15, 2023 17:12 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
December 15, 2023 17:12 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
December 15, 2023 17:12 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
December 15, 2023 17:12 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
December 15, 2023 17:12 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
December 15, 2023 17:12 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
December 15, 2023 17:12 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
December 15, 2023 17:12 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
December 15, 2023 17:12 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
December 15, 2023 17:12 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
December 15, 2023 17:12 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
December 15, 2023 17:12 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
December 15, 2023 17:12 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
December 15, 2023 17:12 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
December 15, 2023 17:12 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
December 15, 2023 17:12 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
December 15, 2023 17:12 — with
GitHub Actions
Inactive
phantumcode
reviewed
Dec 15, 2023
Hi @atierian, I am having issues with the cache files, in my case it is really bad since file sizes are huge. is there a reason why this branch is not merged? |
harsh62
approved these changes
Jul 9, 2024
harsh62
added a commit
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
If a
AWSS3TransferUtilityMultiPartUploadTask
is cancelled by the caller, there's no use keeping the cached file around.According to the File System Programming Guide, the /Library/Caches directory is rarely purged by the system:
Check points:
Added new tests to cover change, if neededUpdated CHANGELOG.mdDocumentation update for the change if requiredBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.