Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IoT): Adding completion callbacks for registerWithShadow and unregisterFromShadow methods #5192

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

sebaland
Copy link
Contributor

@sebaland sebaland commented Feb 9, 2024

Issue #, if available:

Description of changes:

This PR adds the following methods to AWSIoTDataManager:

  • registerWithShadow:options:eventCallback:completionCallback:
  • unregisterFromShadow:completionCallback:

They are basically just overloading the existing ones with the addition of the completionCallback argument, which is invoked when the subscription to all topics is done.

The reasoning behind this is to provide a way for consumers to know when the subscription is actually done and they can get the shadow (see the referenced issue for more information).

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sebaland sebaland force-pushed the ruisebas/adding_callback_register branch from 614cdb1 to 93e171a Compare February 9, 2024 20:35
AWSIoT/AWSIoTDataManager.m Outdated Show resolved Hide resolved
AWSIoT/AWSIoTDataManager.m Show resolved Hide resolved
AWSIoT/AWSIoTDataManager.m Show resolved Hide resolved
@sebaland sebaland temporarily deployed to IntegrationTest June 21, 2024 20:08 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 21, 2024 20:08 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 21, 2024 20:08 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 21, 2024 20:08 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 21, 2024 20:08 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 21, 2024 20:08 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 21, 2024 20:08 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 21, 2024 20:08 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 21, 2024 20:08 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 21, 2024 20:08 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 21, 2024 20:08 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 21, 2024 20:08 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 21, 2024 20:08 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 21, 2024 20:08 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 21, 2024 20:08 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 21, 2024 20:08 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 21, 2024 20:08 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 21, 2024 20:08 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 21, 2024 20:08 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 21, 2024 20:08 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 21, 2024 20:08 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 21, 2024 20:08 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 21, 2024 20:08 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 21, 2024 20:08 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 21, 2024 20:08 — with GitHub Actions Inactive
@sebaland sebaland merged commit a8a72a3 into main Jun 21, 2024
67 checks passed
@sebaland sebaland deleted the ruisebas/adding_callback_register branch June 21, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants