Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove assert doing message validation #5333

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented May 13, 2024

Description of changes:
Fixing failing integration test that is failing on message validation assert. Messages for errors can change on the server, therefore only relying on the code to be correct.

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 requested review from awsmobilesdk and a team as code owners May 13, 2024 18:13
@harsh62 harsh62 temporarily deployed to IntegrationTest May 13, 2024 18:14 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest May 13, 2024 18:14 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest May 13, 2024 18:14 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest May 13, 2024 18:14 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest May 13, 2024 18:14 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest May 13, 2024 18:14 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest May 13, 2024 18:14 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest May 13, 2024 18:14 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest May 13, 2024 18:14 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest May 13, 2024 18:14 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest May 13, 2024 18:14 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest May 13, 2024 18:14 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest May 13, 2024 18:14 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest May 13, 2024 18:14 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest May 13, 2024 18:14 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest May 13, 2024 18:14 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest May 13, 2024 18:14 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest May 13, 2024 18:14 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest May 13, 2024 18:14 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest May 13, 2024 18:14 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest May 13, 2024 18:14 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest May 13, 2024 18:14 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest May 13, 2024 18:14 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest May 13, 2024 18:14 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest May 13, 2024 18:14 — with GitHub Actions Inactive
@harsh62 harsh62 merged commit 098d312 into main May 13, 2024
67 checks passed
@harsh62 harsh62 deleted the update-failing-test branch May 13, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants