Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated sign up UI to accept and format different phone number formats #917

Closed
wants to merge 7 commits into from

Conversation

hatboyzero
Copy link

Replaced logic that simply checked to see if the phone number was in E164 format with implementation that should support most standard phone number inputs.

@mutablealligator mutablealligator added the feature-request Request a new feature label May 3, 2018
@mutablealligator
Copy link
Contributor

Thank you @hatboyzero for submitting a pull request. We are looking into it.

@mutablealligator
Copy link
Contributor

@hatboyzero Can you give us some numbers on the increase in the size of the artifact of the library or the app when you added this dependency?

@vccabral
Copy link

@hatboyzero & @kaustavghosh06 this is a feature I would like as well. Any progress?

I also noticed the forgot username and sign up nav controller doesn't have a back button when I was testing. I have a few other concerns about usability that I need to integrate into my app which are making me move away from the pre-built auth ui you all provide. Any chance that there are a few standard ui components you all would be interested in implementing.

  • phone number custom validation (with a string)
  • email validation with a regex or other
  • custom validators of other types
  • customizable back buttons.

@rohandubal
Copy link
Contributor

Hi, thanks for the PR! Currently we will not be able to merge this PR. But I am referencing this as part of #1158 so that we can include it as part of planning in our next set of tasks.

@rohandubal rohandubal closed this Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cognito Issues related to AWS Cognito
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants