Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't do boto work on the stack resource #3951

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Feb 8, 2025

Issue #, if available:

Description of changes:

  • Don't do boto work on the stack resource

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.79%. Comparing base (510febb) to head (27292a3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3951      +/-   ##
==========================================
- Coverage   93.80%   93.79%   -0.01%     
==========================================
  Files         370      370              
  Lines       12719    12719              
  Branches     2616     2616              
==========================================
- Hits        11931    11930       -1     
  Misses        437      437              
- Partials      351      352       +1     
Flag Coverage Δ
unittests 93.75% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit 53ac0a5 into aws-cloudformation:main Feb 8, 2025
25 checks passed
@kddejong kddejong deleted the schema/boto/stack branch February 8, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant