Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm embedded provider #10

Merged
merged 6 commits into from
Apr 28, 2022
Merged

rm embedded provider #10

merged 6 commits into from
Apr 28, 2022

Conversation

drewmullen
Copy link
Contributor

remvoing in favor of: hashicorp/terraform-provider-awscc#474

embedded providers cause issues:

│ Error: Module module.vpcs.module.vpc_module.module.tags contains provider configuration
│ 
│ Providers cannot be configured within modules using count, for_each or depends_on.

davmayd
davmayd previously approved these changes Apr 28, 2022
View reviewed changes
davmayd
davmayd previously approved these changes Apr 28, 2022
View reviewed changes
tlindsay42
tlindsay42 previously approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@tlindsay42 tlindsay42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a few notes

examples/basic/outputs.tf Outdated Show resolved Hide resolved
examples/basic/outputs.tf Outdated Show resolved Hide resolved
outputs.tf Outdated Show resolved Hide resolved
@drewmullen drewmullen merged commit 9595b11 into main Apr 28, 2022
@drewmullen drewmullen deleted the fix-embedded-provider branch April 28, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlindsay42 tlindsay42 tlindsay42 approved these changes

@davmayd davmayd davmayd left review comments

@tonynv tonynv Awaiting requested review from tonynv tonynv is a code owner

@andrew-glenn andrew-glenn Awaiting requested review from andrew-glenn andrew-glenn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drewmullen @tlindsay42 @davmayd